Skip to content

fix: Kernel - FaceActions - check if batch is available on server - if available use batch project _fill_bodies #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2025

Conversation

echambla
Copy link
Collaborator

@echambla echambla commented Jul 4, 2025

Description

Kernel - FaceActions

  • Check if batch is available on server
  • Use non batch method when creating/reading/updating a single item.
  • If batch is available, use it in project _fill_bodies
    This will induce performance improvement when creating a project from speos file with a lot of faces.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 72.09302% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (4fbf564) to head (1ae8dbd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/speos/core/kernel/face.py 77.41% 7 Missing ⚠️
src/ansys/speos/core/project.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   89.03%   88.90%   -0.13%     
==========================================
  Files          39       39              
  Lines        5581     5616      +35     
==========================================
+ Hits         4969     4993      +24     
- Misses        612      623      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene
Copy link
Collaborator

@jomadec can you review this?

@StefanThoene StefanThoene merged commit 689d751 into main Jul 15, 2025
24 checks passed
@StefanThoene StefanThoene deleted the bugs/fix-pyspeos-usage-server-251 branch July 15, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants