Skip to content

feat: add export result as vtp files #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 7, 2025
Merged

feat: add export result as vtp files #643

merged 26 commits into from
Jul 7, 2025

Conversation

pluAtAnsys
Copy link
Collaborator

@pluAtAnsys pluAtAnsys commented Jun 25, 2025

Description

method to allow generating vtp from XM3 or irradiance XMP results.

Issue linked

generate results into vtp #642

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@pluAtAnsys pluAtAnsys linked an issue Jun 25, 2025 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 25, 2025
@pluAtAnsys pluAtAnsys changed the title add method to allow export simulation result as vtp files feat: add export result as vtp files Jun 25, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (999b0bd) to head (c997976).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/speos/core/simulation.py 15.62% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   89.44%   89.02%   -0.43%     
==========================================
  Files          39       39              
  Lines        5544     5574      +30     
==========================================
+ Hits         4959     4962       +3     
- Misses        585      612      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pluAtAnsys pluAtAnsys self-assigned this Jul 2, 2025
@pluAtAnsys pluAtAnsys requested a review from StefanThoene July 3, 2025 19:57
avoid getting the path when filter result
StefanThoene
StefanThoene previously approved these changes Jul 4, 2025
@pluAtAnsys pluAtAnsys marked this pull request as ready for review July 4, 2025 13:39
@pluAtAnsys pluAtAnsys requested a review from StefanThoene July 4, 2025 13:39
@pluAtAnsys pluAtAnsys merged commit 011c9ae into main Jul 7, 2025
28 checks passed
@pluAtAnsys pluAtAnsys deleted the feat/export-vtp branch July 7, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate results into vtp
3 participants