-
Notifications
You must be signed in to change notification settings - Fork 165
FEAT: EM fields in Q3D #6421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: EM fields in Q3D #6421
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
==========================================
+ Coverage 85.09% 85.13% +0.03%
==========================================
Files 176 176
Lines 66873 66944 +71
==========================================
+ Hits 56907 56990 +83
+ Misses 9966 9954 -12 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments on the PR. I didn't propose all the required changes as the same pattern applies multiple times and I got tired of doing it ^^
Just wondering but could we make Q3D leverage CreateBoundaryMixin
since some methods are creating boundaries ? I can do that in another PR if you want, let me know :)
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add Q3D new feature of EM Fields. This is equivalent to Near Field setup in HFSS, so it shares the same classes, showing the power of PyAEDT :)
Issue linked
Close #6059
Checklist