Skip to content

FEAT: EM fields in Q3D #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 18, 2025
Merged

FEAT: EM fields in Q3D #6421

merged 20 commits into from
Jul 18, 2025

Conversation

Samuelopez-ansys
Copy link
Member

Description

Add Q3D new feature of EM Fields. This is equivalent to Near Field setup in HFSS, so it shares the same classes, showing the power of PyAEDT :)

Issue linked

Close #6059

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner July 16, 2025 10:20
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jul 16, 2025
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (6f45688) to head (986e3f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6421      +/-   ##
==========================================
+ Coverage   85.09%   85.13%   +0.03%     
==========================================
  Files         176      176              
  Lines       66873    66944      +71     
==========================================
+ Hits        56907    56990      +83     
+ Misses       9966     9954      -12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments on the PR. I didn't propose all the required changes as the same pattern applies multiple times and I got tired of doing it ^^

Just wondering but could we make Q3D leverage CreateBoundaryMixin since some methods are creating boundaries ? I can do that in another PR if you want, let me know :)

SMoraisAnsys
SMoraisAnsys previously approved these changes Jul 17, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit ebd0ebb into main Jul 18, 2025
37 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_6059 branch July 18, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Methods for Radiation Setups in Q3D
4 participants