Skip to content

REFACTOR: 6375 migrate shielding effectiveness extension #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

eblanco-ansys
Copy link
Contributor

Description

  • Migrated shielding effectiveness extension to new standard
  • Added tests
  • Small UI improvement adding a selector

Issue linked

#6375

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys eblanco-ansys requested a review from a team as a code owner July 10, 2025 09:19
@eblanco-ansys eblanco-ansys linked an issue Jul 10, 2025 that may be closed by this pull request
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@eblanco-ansys eblanco-ansys self-assigned this Jul 10, 2025
@eblanco-ansys eblanco-ansys changed the title 6375 migrate shielding effectiveness extension REFACTOR: 6375 migrate shielding effectiveness extension Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 87.82051% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (710ce3a) to head (21dd567).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6379      +/-   ##
==========================================
- Coverage   85.36%   83.03%   -2.33%     
==========================================
  Files         175      175              
  Lines       65989    66266     +277     
==========================================
- Hits        56333    55027    -1306     
- Misses       9656    11239    +1583     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate shielding effectiveness extension
2 participants