-
Notifications
You must be signed in to change notification settings - Fork 14
ci: Run CI on pushes to all branches #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@guidograzioli What's your feeling about this PR? |
We create PRs from forks, not branches, so I do not see real value in this change tbh |
Of course, that's not the point. The current setup forces contributors to develop in |
I've just added another commit that prevents running the Documentation job in forks because it does not work there. edit: See that the referenced action expects the repository contains tags, which does not have to be true. |
@guidograzioli Could you look at the proposed change again? As I tried to explain, it's especially useful in forks because the |
9a2be14
to
225e774
Compare
rebase & ping |
Dropping this as it's now part of #291. Second look on this PR is still welcomed though. |
It's imho better to find potential issues before creating a PR. And development in the
main
branch is not ideal (definitely not for any bigger changes...)