Skip to content

ci: Run CI on pushes to all branches #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jajik
Copy link
Contributor

@jajik jajik commented Nov 5, 2024

It's imho better to find potential issues before creating a PR. And development in the main branch is not ideal (definitely not for any bigger changes...)

@rpelisse
Copy link
Contributor

rpelisse commented Nov 6, 2024

@guidograzioli What's your feeling about this PR?

@guidograzioli
Copy link
Member

We create PRs from forks, not branches, so I do not see real value in this change tbh

@jajik
Copy link
Contributor Author

jajik commented Nov 6, 2024

We create PRs from forks, not branches, so I do not see real value in this change tbh

Of course, that's not the point. The current setup forces contributors to develop in main in case they want to run CI before creating a PR, or to modify their ci.yml which is annoying with regard to synchronization.

@jajik
Copy link
Contributor Author

jajik commented Nov 13, 2024

I've just added another commit that prevents running the Documentation job in forks because it does not work there.

edit: See that the referenced action expects the repository contains tags, which does not have to be true.
edit2: e.g. https://github.com/jajik/jws-ansible-collection/actions/runs/11853814361/job/33034679384

@jajik
Copy link
Contributor Author

jajik commented Nov 15, 2024

We create PRs from forks, not branches, so I do not see real value in this change tbh

@guidograzioli Could you look at the proposed change again? As I tried to explain, it's especially useful in forks because the ci.yml gets used there as well. Currently, you're preventing people from running CI in their forks unless they're developing in main or they change the ci.yml. Both of these make rebasing more annoying than necessary. The advantage seems obvious, e.g., people open PRs with changes that actually work in CI...

@jajik
Copy link
Contributor Author

jajik commented Nov 28, 2024

^^ @guidograzioli @rpelisse

@jajik
Copy link
Contributor Author

jajik commented Dec 12, 2024

rebase & ping

@jajik
Copy link
Contributor Author

jajik commented Jan 2, 2025

I've just added another commit that prevents running the Documentation job in forks because it does not work there.

edit: See that the referenced action expects the repository contains tags, which does not have to be true. edit2: e.g. https://github.com/jajik/jws-ansible-collection/actions/runs/11853814361/job/33034679384

Dropping this as it's now part of #291.

Second look on this PR is still welcomed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants