feat(efa): add validation for EFA on single node (aws#657)

Author: mselim00

test/cases/efa/commons.go

@@ -79,7 +79,7 @@ func getEfaNodes(ctx context.Context, config *envconf.Config) ([]corev1.Node, er
 		}
 
 		expectedDeviceCount := aws.ToInt(expectedEFADeviceCount)
-		if expectedDeviceCount == 0 {
+		if expectedDeviceCount < 0 {
 			instanceInfo, err := ec2Client.DescribeInstanceType(instanceType)
 			if err != nil {
 				return []corev1.Node{}, err

test/cases/efa/main_test.go

@@ -55,7 +55,7 @@ func TestMain(m *testing.M) {
 	pingPongIters = flag.Int("pingPongIters", 10000, "number of iterations to use for ping pong")
 	pingPongDeadlineSeconds = flag.Int("pingPongDeadlineSeconds", 120, "maximum run time for a ping pong attempt")
 	nodeType = flag.String("nodeType", "", "instance type to target for tests")
-	expectedEFADeviceCount = flag.Int("expectedEFADeviceCount", 0, "expected number of efa devices for the target nodes")
+	expectedEFADeviceCount = flag.Int("expectedEFADeviceCount", -1, "expected number of efa devices for the target nodes")
 	verbose = flag.Bool("verbose", true, "use verbose mode for tests")
 
 	cfg, err := envconf.NewFromFlags()

test/images/efa/Dockerfile

@@ -1,5 +1,7 @@
 FROM public.ecr.aws/amazonlinux/amazonlinux:2023
 
+ARG EFA_BIN_PATH="/opt/amazon/efa/bin"
+
 RUN dnf -y swap gnupg2-minimal gnupg2 && \
     dnf install -y \
     gcc gcc-c++ make \  
@@ -25,7 +27,7 @@ RUN dnf -y swap gnupg2-minimal gnupg2 && \
     tar \
     gnupg2 
 
-ENV PATH="$PATH:/opt/amazon/efa/bin"
+ENV PATH="$PATH:$EFA_BIN_PATH"
 
 RUN cd $HOME \
     && curl -O https://efa-installer.amazonaws.com/aws-efa-installer-latest.tar.gz \
@@ -35,6 +37,10 @@ RUN cd $HOME \
     && tar -xf aws-efa-installer-latest.tar.gz \
     && cd aws-efa-installer \
     && ./efa_installer.sh -y -d --skip-kmod --skip-limit-conf --no-verify \
+    # TODO: remove this in favor of letting the efa installer add it if that ever becomes an option.
+    # At the moment, this is only installed if omitting --no-verify, which would require
+    # building in a context with EFA available
+    && install -T -m 0755 efa_test.sh "${EFA_BIN_PATH}/efa_test.sh" \
     && cd $HOME \
     && rm -rf aws-efa-installer
 

test/images/efa/scripts/unit-test.sh

@@ -41,4 +41,10 @@ else
     echo "Verified at least $EXPECTED_EFA_DEVICE_COUNT RDM endpoint(s) are available (found $RDM_ENDPOINT_COUNT)"
 fi
 
+
+echo "Running single-node efa test"
+
+# Run efa_test.sh, a utility added during the build while installing EFA
+efa_test.sh
+
 echo "Success!"