Skip to content

Commit c26cd50

Browse files
Alex7D3BrayanDSO
authored andcommitted
Fix deck menu remaining open after editing description
When dismissing EditDeckDescriptionDialog, dismiss all dialog fragments to close DeckPickerContextMenu. This prevents the context menu from appearing on top of the keyboard and is closer to the behavior of other menu actions.
1 parent 606df12 commit c26cd50

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/EditDeckDescriptionDialog.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import com.ichi2.anki.StudyOptionsFragment
3939
import com.ichi2.anki.dialogs.EditDeckDescriptionDialogViewModel.DismissType
4040
import com.ichi2.anki.libanki.DeckId
4141
import com.ichi2.anki.snackbar.showSnackbar
42+
import com.ichi2.anki.utils.ext.dismissAllDialogFragments
4243
import com.ichi2.utils.AndroidUiUtils.hideKeyboard
4344
import com.ichi2.utils.AndroidUiUtils.setFocusAndOpenKeyboard
4445
import com.ichi2.utils.create
@@ -150,9 +151,9 @@ class EditDeckDescriptionDialog : DialogFragment() {
150151
.filterNotNull()
151152
.collect { dismissType ->
152153
when (dismissType) {
153-
DismissType.ClosedWithoutSaving -> dismiss()
154+
DismissType.ClosedWithoutSaving -> requireActivity().dismissAllDialogFragments()
154155
DismissType.Saved -> {
155-
dismiss()
156+
requireActivity().dismissAllDialogFragments()
156157
showSnackbar(R.string.deck_description_saved)
157158
// notify DeckPicker to invalidate its toolbar menu, otherwise the undo
158159
// action to revert the description change is not going to be visible

0 commit comments

Comments
 (0)