Skip to content

Commit 8c352ec

Browse files
lukstbitmikehardy
authored andcommitted
Remove "app.brant.amazonappstorepublisher" plugin
The plugin hasn't been updated for quite some time and it currently breaks the build and apk publishing. This PR removes it along its configuration and any additional setup code. The plugin was already removed from the publishing process as it didn't work anymore. See #14161
1 parent 336736f commit 8c352ec

File tree

4 files changed

+0
-34
lines changed

4 files changed

+0
-34
lines changed

AnkiDroid/build.gradle

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ plugins {
22
// Gradle plugin portal
33
alias(libs.plugins.tripletPlay)
44
alias(libs.plugins.android.application)
5-
alias(libs.plugins.amazonappstorepublisher)
65
alias(libs.plugins.kotlin.android)
76
alias(libs.plugins.kotlin.parcelize)
87
alias(libs.plugins.kotlin.serialization)
@@ -269,13 +268,6 @@ play {
269268
track.set('alpha')
270269
}
271270

272-
amazon {
273-
securityProfile = file("${homePath}/src/AnkiDroid-Amazon-Publish-Security-Profile.json")
274-
applicationId = "amzn1.devportal.mobileapp.524a424d314931494c55383833305539"
275-
pathToApks = [ file("./build/outputs/apk/amazon/release/AnkiDroid-amazon-universal-release.apk") ]
276-
replaceEdit = true
277-
}
278-
279271
// Install Git pre-commit hook for Ktlint
280272
tasks.register('installGitHook', Copy) {
281273
from new File(rootProject.rootDir, 'pre-commit')

build.gradle.kts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,6 @@ import java.io.ByteArrayOutputStream
88
import kotlin.math.max
99

1010
// Top-level build file where you can add configuration options common to all sub-projects/modules.
11-
buildscript {
12-
configurations.configureEach {
13-
resolutionStrategy.eachDependency {
14-
val version = requested.version
15-
if (requested.group == "org.jetbrains.kotlinx"
16-
&& requested.name.contains("kotlinx-serialization-runtime")
17-
&& (version != null && version.contains("0.11.0"))
18-
) {
19-
useVersion("0.14.0")
20-
}
21-
}
22-
}
23-
}
24-
2511
plugins {
2612
alias(libs.plugins.android.application) apply false
2713
alias(libs.plugins.android.library) apply false

gradle/libs.versions.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ compileSdk = "34"
33
minSdk = "23" # also in testlib/build.gradle.kts
44
targetSdk = "34" # also in ../robolectricDownloader.gradle
55
acra = '5.11.3'
6-
amazonappstorepublisher = "0.1.0"
76
androidGradlePlugin = "8.5.1"
87
androidxActivity = "1.9.0"
98
androidxAnnotation = "1.8.0"
@@ -162,8 +161,6 @@ cashapp-turbine = { module = "app.cash.turbine:turbine", version.ref = "turbine"
162161

163162
android-application = { id = "com.android.application", version.ref = "androidGradlePlugin" }
164163
android-library = { id = "com.android.library", version.ref = "androidGradlePlugin" }
165-
amazonappstorepublisher = { id = "app.brant.amazonappstorepublisher", version.ref = "amazonappstorepublisher" }
166-
167164

168165
tripletPlay = { id = "com.github.triplet.play", version.ref = "triplet" }
169166

settings.gradle.kts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@ pluginManagement {
33
google()
44
gradlePluginPortal()
55
mavenCentral()
6-
maven(url = "https://jitpack.io") // only needed for the "amazonappstorepublisher" plugin
7-
}
8-
resolutionStrategy {
9-
// TODO try to find another plugin for this functionality?
10-
eachPlugin {
11-
if (requested.id.id == "app.brant.amazonappstorepublisher") {
12-
useModule("com.github.BrantApps.gradle-amazon-app-store-publisher:amazonappstorepublisher:master-SNAPSHOT")
13-
}
14-
}
156
}
167
}
178

0 commit comments

Comments
 (0)