improvement: upgrade double tap time interval to a SliderPreference

Which is easier to setup.

Included changes:
- Maximum time was reduced from 2000ms to 1000ms
- The `stepSize` is 10ms to make it easier to setup
- `(milisseconds)` was removed from the title because the display already show that the unit is ms
    - Only did that in the English translation because I don't think that it is worth to remove all the other translations just for that.

Author: BrayanDSO

AnkiDroid/src/main/java/com/ichi2/anki/analytics/UsageAnalytics.kt

@@ -485,7 +485,7 @@ object UsageAnalytics {
             R.string.learn_cutoff_preference, // Learn ahead limit
             R.string.time_limit_preference, // Timebox time limit
             R.string.keep_screen_on_preference, // Disable screen timeout
-            R.string.double_tap_time_interval_preference, // Double tap time interval (milliseconds)
+            R.string.double_tap_timeout_pref_key, // Double tap time interval (milliseconds)
             // ******************************** Sync ***************************************************
             R.string.sync_fetch_media_key, // Fetch media on sync
             R.string.automatic_sync_choice_key, // Automatic synchronization

AnkiDroid/src/main/java/com/ichi2/anki/servicelayer/PreferenceUpgradeService.kt

@@ -57,6 +57,7 @@ import com.ichi2.utils.HashUtil.hashSetInit
 import timber.log.Timber
 import java.util.Locale
 import kotlin.collections.ArrayList
+import kotlin.math.round
 
 private typealias VersionIdentifier = Int
 private typealias LegacyVersionIdentifier = Long
@@ -128,6 +129,7 @@ object PreferenceUpgradeService {
                     yield(UpgradeBrowserColumns())
                     yield(RemoveLastExportedAtTime())
                     yield(RemoveLongTouchGesture())
+                    yield(UpgradeDoubleTapTimeout())
                 }
 
             /** Returns a list of preference upgrade classes which have not been applied */
@@ -695,6 +697,26 @@ object PreferenceUpgradeService {
                 }
             }
         }
+
+        internal class UpgradeDoubleTapTimeout : PreferenceUpgrade(22) {
+            override fun upgrade(preferences: SharedPreferences) {
+                val oldPrefKey = "doubleTapTimeInterval"
+                val value = preferences.getInt(oldPrefKey, -1)
+                if (value == -1) return
+                val newValue =
+                    if (value > 1000) {
+                        1000
+                    } else {
+                        val result = value / 10.0
+                        val roundedResult = round(result)
+                        (roundedResult * 10).toInt()
+                    }
+                preferences.edit {
+                    remove(oldPrefKey)
+                    putInt("doubleTapTimeout", newValue)
+                }
+            }
+        }
     }
 }
 

AnkiDroid/src/main/java/com/ichi2/anki/settings/Prefs.kt

@@ -179,7 +179,7 @@ object Prefs {
 
     // **************************************** Reviewer **************************************** //
 
-    val doubleTapInterval by intPref(R.string.double_tap_time_interval_preference, defaultValue = 200)
+    val doubleTapInterval by intPref(R.string.double_tap_timeout_pref_key, defaultValue = 200)
     val ignoreDisplayCutout by booleanPref(R.string.ignore_display_cutout_key, false)
     val autoFocusTypeAnswer by booleanPref(R.string.type_in_answer_focus_key, true)
     val showAnswerFeedback by booleanPref(R.string.show_answer_feedback_key, defaultValue = true)

AnkiDroid/src/main/res/values/10-preferences.xml

@@ -139,7 +139,7 @@
     <string name="disable_extended_text_ui_summ">Allows \'Cloze Deletion\' context menu when in landscape mode.</string>
     <string name="vertical_centering" maxLength="41">Center align</string>
     <string name="vertical_centering_summ">Center the content of cards vertically</string>
-    <string name="pref_double_tap_time_interval" maxLength="41">Double tap time interval (milliseconds)</string>
+    <string name="pref_double_tap_time_interval" maxLength="41">Double tap time interval</string>
     <string name="pref_double_tap_time_interval_summary">A second tap of the answer buttons will be ignored if this time has not elapsed. This prevents accidental double taps</string>
     <string name="pref_show_answer_long_press_time" maxLength="41">Show answer long-press time</string>
     <string name="pref_show_answer_long_press_time_summary">Minimum pressing time before the show answer button registers a touch.</string>

AnkiDroid/src/main/res/values/preferences.xml

@@ -13,7 +13,7 @@
     <string name="learn_cutoff_preference">learnCutoff</string>
     <string name="time_limit_preference">timeLimit</string>
     <string name="keep_screen_on_preference">keepScreenOn</string>
-    <string name="double_tap_time_interval_preference">doubleTapTimeInterval</string>
+    <string name="double_tap_timeout_pref_key">doubleTapTimeout</string>
     <!-- Sync -->
     <string name="pref_sync_screen_key">syncScreen</string>
     <string name="sync_account_key">syncAccount</string>

AnkiDroid/src/main/res/xml/preferences_reviewing.xml

@@ -55,12 +55,15 @@
             android:key="@string/keep_screen_on_preference"
             android:summary="@string/pref_keep_screen_on_summ"
             android:title="@string/pref_keep_screen_on" />
-        <com.ichi2.preferences.NumberRangePreferenceCompat
-            android:defaultValue="200"
-            android:key="@string/double_tap_time_interval_preference"
-            android:summary="@string/pref_double_tap_time_interval_summary"
+        <com.ichi2.preferences.SliderPreference
+            android:key="@string/double_tap_timeout_pref_key"
             android:title="@string/pref_double_tap_time_interval"
-            app:min="0"
-            app:max="2000" />
+            android:summary="@string/pref_double_tap_time_interval_summary"
+            android:valueFrom="0"
+            android:valueTo="1000"
+            android:defaultValue="200"
+            android:stepSize="10"
+            app1:displayFormat="@string/pref_milliseconds"
+            />
     </PreferenceCategory>
 </PreferenceScreen>

AnkiDroid/src/test/java/com/ichi2/anki/servicemodel/PreferenceUpgradeServiceTest.kt

@@ -174,6 +174,23 @@ class PreferenceUpgradeServiceTest : RobolectricTest() {
         assertThat(prefs.getString("syncFetchMedia", null), equalTo("never"))
     }
 
+    @Test
+    fun `Double tap timeout is converted correctly`() {
+        fun testValue(
+            oldValue: Int,
+            expectedValue: Int,
+        ) {
+            prefs.edit { putInt("doubleTapTimeInterval", oldValue) }
+            PreferenceUpgrade.UpgradeDoubleTapTimeout().performUpgrade(prefs)
+            assertThat(prefs.getInt("doubleTapTimeout", -1), equalTo(expectedValue))
+        }
+        testValue(oldValue = 395, expectedValue = 400)
+        testValue(oldValue = 25, expectedValue = 20)
+        testValue(oldValue = 200, expectedValue = 200)
+        testValue(oldValue = 0, expectedValue = 0)
+        testValue(oldValue = 1350, expectedValue = 1000)
+    }
+
     // ############################
     // ##### UpgradeAppLocale #####
     // ############################