Skip to content

Commit 00dd397

Browse files
BrayanDSOmikehardy
authored andcommitted
refactor: set PageFragment layout in the constructor
1 parent fd01dfc commit 00dd397

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/pages/PageFragment.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import android.webkit.WebChromeClient
2121
import android.webkit.WebView
2222
import android.webkit.WebViewClient
2323
import androidx.annotation.CallSuper
24+
import androidx.annotation.LayoutRes
2425
import androidx.fragment.app.Fragment
2526
import com.google.android.material.appbar.MaterialToolbar
2627
import com.ichi2.anki.R
@@ -31,7 +32,10 @@ import timber.log.Timber
3132
* Base class for displaying Anki HTML pages
3233
*/
3334
@Suppress("LeakingThis")
34-
abstract class PageFragment : Fragment(R.layout.page_fragment), PostRequestHandler {
35+
abstract class PageFragment(@LayoutRes contentLayoutId: Int = R.layout.page_fragment) :
36+
Fragment(contentLayoutId),
37+
PostRequestHandler {
38+
3539
abstract val title: String
3640
abstract val pageName: String
3741

AnkiDroid/src/main/java/com/ichi2/anki/pages/Statistics.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ import android.content.Intent
2020
import android.os.Bundle
2121
import android.print.PrintAttributes
2222
import android.print.PrintManager
23-
import android.view.LayoutInflater
2423
import android.view.View
25-
import android.view.ViewGroup
2624
import androidx.core.content.ContextCompat.getSystemService
2725
import com.google.android.material.appbar.MaterialToolbar
2826
import com.ichi2.anki.CollectionManager
@@ -31,18 +29,11 @@ import com.ichi2.anki.SingleFragmentActivity
3129
import com.ichi2.anki.utils.getTimestamp
3230
import com.ichi2.libanki.utils.TimeManager
3331

34-
class Statistics : PageFragment() {
32+
class Statistics : PageFragment(R.layout.statistics) {
3533
override val title: String
3634
get() = resources.getString(R.string.statistics)
3735

3836
override val pageName = "graphs"
39-
override fun onCreateView(
40-
inflater: LayoutInflater,
41-
container: ViewGroup?,
42-
savedInstanceState: Bundle?
43-
): View? {
44-
return inflater.inflate(R.layout.statistics, container, false)
45-
}
4637

4738
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
4839
super.onViewCreated(view, savedInstanceState)

0 commit comments

Comments
 (0)