Merge pull request #240 from animint/fix-legend

identical instead of ==

Author: tdhock

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: animint2
 Title: Animated Interactive Grammar of Graphics
-Version: 2025.9.30
+Version: 2025.10.3
 URL: https://animint.github.io/animint2/
 BugReports: https://github.com/animint/animint2/issues
 Authors@R: c(

NEWS.md

@@ -1,3 +1,7 @@
+# Changes in version 2025.10.3 (PR#240)
+
+- `guide_legend(override.aes)` works in a plot with both color and fill legends.
+
 # Changes in version 2025.9.30 (PR#239)
 
 - `getCommonChunk()` has new atime performance test.

R/z_animint.R

@@ -750,7 +750,7 @@ getLegendList <- function(plistextra){
     }else{
       "legend"
     }
-    if(guide.type=="colourbar")guide.type <- "legend"
+    if(identical(guide.type,"colourbar"))guide.type <- "legend"
     guides.args[[aes.name]] <- guide.type
   }
   guides.result <- do.call(guides, guides.args)

tests/testthat/test-compiler-guides.R

@@ -3,8 +3,20 @@ context("Guides")
 test_that("colourbar trains without labels", {
   g <- guide_colorbar()
   sc <- scale_colour_continuous(limits = c(0, 4), labels = NULL)
-
   out <- guide_train(g, sc)
   expect_equal(names(out$key), c("colour", ".value"))
 })
 
+test_that("no error for override fill white", {
+  viz <- animint(
+    ggplot()+
+      geom_tile(aes(
+        x, x, color=y, fill=x),
+        data=data.frame(x=seq(-1,1), y=0:2))+
+      scale_color_gradient(
+        low="white",high="black",
+        guide=guide_legend(override.aes=list(fill="white")))+
+      scale_fill_gradient2())
+  info <- animint2dir(viz, open.browser = FALSE)
+  expect_is(info, "environment")
+})