Apply maintainer feedback for PR#246

- Update NEWS.md to reference PR#246 instead of Issue #232
- Refactor checkSelectorNames() to use sprintf instead of paste0
- Remove unnecessary if(length==0) check and explicit return(NULL)
- Remove all empty lines from test_that blocks per style guidelines

Author: ANAMASGARD

NEWS.md

@@ -1,12 +1,10 @@
-<<<<<<< HEAD
 # Changes in version 2025.10.9 (PR#242)
 
 - Improve common chunk detection, output `na_group` and `row_in_group` when there are missing values.
-=======
-# Changes in version 2025.10.6 (Issue #232)
+
+# Changes in version 2025.10.6 (PR#246)
 
 - Added validation for selector names to prevent browser rendering failures. Selector names (from data values used in `clickSelects` and `showSelected`) cannot contain CSS special characters like `#`, `@`, `!`, `$`, etc., as these interfere with JavaScript DOM selectors and cause blank visualizations in the browser. The compiler now stops with a clear error message identifying problematic selector names, helping users fix data issues before attempting to render.
->>>>>>> 32e15c5d (Add validation for selector names to prevent browser rendering failures(#232).)
 
 # Changes in version 2025.10.3 (PR#240)
 

R/z_animintHelpers.R

@@ -642,10 +642,6 @@ checkSingleShowSelectedValue <- function(selectors){
 #' @param selectors selectors to validate
 #' @return \code{NULL}. Throws error if invalid characters found.
 checkSelectorNames <- function(selectors){
-  if(length(selectors) == 0){
-    return(NULL)
-  }
-  
   selector.names <- names(selectors)
 
   ## Characters that are invalid in CSS selectors and cause issues in browser
@@ -671,18 +667,17 @@ checkSelectorNames <- function(selectors){
       paste0("'", found.chars, "'", collapse = ", ")
     })
 
-    error.msg <- paste0(
+    error.msg <- sprintf(
+      "%s%s\n%s\n%s\n\n%s",
       "Invalid character(s) in selector name(s). ",
-      "Selector names cannot contain special characters that interfere with CSS selectors.\n",
-      "The following selector(s) contain invalid characters:\n",
+      "Selector names cannot contain special characters that interfere with CSS selectors.",
+      "The following selector(s) contain invalid characters:",
       paste0("  - '", invalid.names, "' contains ", problematic, collapse = "\n"),
-      "\n\nPlease remove or replace these characters in your variable names."
+      "Please remove or replace these characters in your variable names."
     )
 
     stop(error.msg)
   }
-  
-  return(NULL)
 }
 
 

tests/testthat/test-compiler-invalid-selector-characters.R

@@ -16,13 +16,11 @@ test_that("selector name with # causes error in clickSelects", {
         clickSelects = c(regularization = "parameter")
       )
   )
-  
   expect_error(
     animint2dir(viz, open.browser = FALSE),
     "Invalid character\\(s\\) in selector name\\(s\\)",
     info = "Selector names with '#' should cause an error"
   )
-  
   expect_error(
     animint2dir(viz, open.browser = FALSE),
     "# nearest neighbors",
@@ -44,13 +42,11 @@ test_that("selector name with @ causes error in clickSelects", {
         clickSelects = c(regularization = "parameter")
       )
   )
-  
   expect_error(
     animint2dir(viz, open.browser = FALSE),
     "Invalid character\\(s\\) in selector name\\(s\\)",
     info = "Selector names with '@' should cause an error"
   )
-  
   expect_error(
     animint2dir(viz, open.browser = FALSE),
     "model@version",
@@ -70,7 +66,6 @@ test_that("selector name with ! causes error", {
         clickSelects = c(model = "parameter")
       )
   )
-  
   expect_error(
     animint2dir(viz, open.browser = FALSE),
     "Invalid character\\(s\\) in selector name\\(s\\)",
@@ -90,8 +85,6 @@ test_that("valid selector names work with clickSelects", {
         clickSelects = c(regularization = "parameter")
       )
   )
-  
-  # Should NOT error
   info <- animint2dir(viz, open.browser = FALSE)
   expect_true(TRUE, info = "Valid selector names should not cause errors")
 })
@@ -108,8 +101,6 @@ test_that("selector names with spaces work", {
         clickSelects = c(regularization = "parameter")
       )
   )
-  
-  # Should NOT error - spaces are fine
   info <- animint2dir(viz, open.browser = FALSE)
   expect_true(TRUE, info = "Selector names with spaces should work")
 })
@@ -126,13 +117,10 @@ test_that("multiple values with invalid characters all reported", {
         clickSelects = c(regularization = "parameter")
       )
   )
-  
   error_msg <- tryCatch(
     animint2dir(viz, open.browser = FALSE),
     error = function(e) as.character(e$message)
   )
-  
-  # Should catch both bad selector names
   expect_match(error_msg, "Invalid character", info = "Should report invalid characters")
   expect_match(error_msg, "#bad|!worse", info = "Should mention at least one problematic selector")
 })