[BUG]: anidl wrongly exits with the error code 0 (success) upon failures

[Ravencentric]

Program version

5.3.7

Operating System

Windows

Type

CLI

Service

Crunchyroll

Command used

aniDL.exe --service crunchy --srz GDKHZEJ0K -e 1

Show ID

GDKHZEJ0K

Episode

1

Console Output

❯ ./aniDL.exe --service crunchy --username "redacted" --password 'redacted' --srz GDKHZEJ0K -e 1

=== Multi Downloader NX 5.3.7 ===

USER: redacted (redacted)
Your Country: redacted

[Z:GDKHZEJ0K] Solo Leveling (Seasons: 2, EPs: 26) [SIMULCAST, SUB, DUB]
  - Subtitles: en, es-419, es-ES, pt-BR, fr, de, ar, it, ru, hi, zh-CN, zh-HK, th-TH, ta-IN, ms-MY, vi-VN, id-ID, te-IN
  [S:GR19CPDWM] Solo Leveling (Season: 1) [SUB, DUB]
    - Versions: en, es-419, es-ES, pt-BR, fr, de, it, hi, ko, ta-IN, te-IN, ja
    - Subtitles: en, es-419, es-ES, pt-BR, fr, de, ar, it, ru, th-TH, ms-MY, vi-VN, id-ID
  [S:GY09CX813] Solo Leveling Season 2 -Arise from the Shadow- (Season: 2) [SIMULCAST, SUB, DUB]
    - Versions: en, es-419, es-ES, pt-BR, fr, de, it, hi, ko, ta-IN, te-IN, ja
    - Subtitles: en, es-419, es-ES, pt-BR, fr, de, ar, it, ru, zh-CN, zh-HK, th-TH, ms-MY, vi-VN, id-ID
[E1] [2024-01-06] Solo Leveling - Season 1 - I'm Used to It [Japanese, Hindi, Portuguese, Spanish, German, French, Italian, Castilian, Tamil (India), Telugu (India), English, Korean]
[E2] [2024-01-13] Solo Leveling - Season 1 - If I Had One More Chance [Japanese, Portuguese, German, Italian, French, Telugu (India), Tamil (India), Spanish, Hindi, English, Castilian, Korean]
[E3] [2024-01-20] Solo Leveling - Season 1 - It's Like a Game [Japanese, Portuguese, German, French, Spanish, Italian, Telugu (India), Hindi, Tamil (India), English, Castilian, Korean]
[E4] [2024-01-27] Solo Leveling - Season 1 - I've Gotta Get Stronger [Japanese, Portuguese, German, French, Italian, Spanish, Tamil (India), Hindi, Telugu (India), English, Castilian, Korean]
[E5] [2024-02-03] Solo Leveling - Season 1 - A Pretty Good Deal [Japanese, German, Portuguese, Spanish, Italian, Hindi, Telugu (India), French, Tamil (India), English, Castilian, Korean]
[E6] [2024-02-10] Solo Leveling - Season 1 - The Real Hunt Begins [Japanese, Portuguese, German, Spanish, Italian, Hindi, Telugu (India), French, Tamil (India), English, Castilian, Korean]
[E7] [2024-02-17] Solo Leveling - Season 1 - Let's See How Far I Can Go [Japanese, German, Portuguese, Spanish, French, Italian, Telugu (India), Tamil (India), English, Hindi, Castilian, Korean]
[E8] [2024-03-02] Solo Leveling - Season 1 - This Is Frustrating [Japanese, Portuguese, German, Spanish, Italian, French, Telugu (India), Tamil (India), English, Castilian, Korean, Hindi]
[E9] [2024-03-09] Solo Leveling - Season 1 - You've Been Hiding Your Skills [Japanese, German, Portuguese, Spanish, Italian, Tamil (India), Telugu (India), French, English, Castilian, Korean, Hindi]
[E10] [2024-03-16] Solo Leveling - Season 1 - What Is This, a Picnic? [Japanese, Portuguese, Spanish, English, Korean, German, French, Italian, Tamil (India), Telugu (India), Hindi, Castilian]
[E11] [2024-03-23] Solo Leveling - Season 1 - A Knight Who Defends an Empty Throne [Japanese, Korean, Tamil (India), Telugu (India), English, German, Portuguese, Spanish, French, Castilian, Italian, Hindi]
[E12] [2024-03-30] Solo Leveling - Season 1 - Arise [Japanese, Korean, Castilian, Tamil (India), Telugu (India), English, Portuguese, French, German, Spanish, Hindi, Italian]
[E13] [2025-01-04] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - You Aren't E-Rank, Are You? [☆ Japanese, ☆ English, ☆ Spanish, ☆ Portuguese, ☆ German, ☆ Italian, ☆ Castilian, ☆ French, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India), ☆ Korean]
[E14] [2025-01-11] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - I Suppose You Aren't Aware [☆ Japanese, ☆ English, ☆ Portuguese, ☆ Spanish, ☆ German, ☆ Italian, ☆ French, ☆ Castilian, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India), ☆ Korean]
[E15] [2025-01-18] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - Still a Long Way to Go [☆ Japanese, ☆ English, ☆ Portuguese, ☆ German, ☆ Spanish, ☆ French, ☆ Italian, ☆ Castilian, ☆ Telugu (India), ☆ Hindi, ☆ Tamil (India), ☆ Korean]
[E16] [2025-01-25] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - I Need to Stop Faking [☆ Japanese, ☆ English, ☆ Portuguese, ☆ French, ☆ German, ☆ Spanish, ☆ Castilian, ☆ Hindi, ☆ Italian, ☆ Tamil (India), ☆ Telugu (India), ☆ Korean]
[E17] [2025-02-01] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - This Is What We're Trained to Do [☆ Japanese, ☆ Korean, ☆ Portuguese, ☆ German, ☆ French, ☆ Castilian, ☆ Italian, ☆ Hindi, ☆ Telugu (India), ☆ Tamil (India), ☆ English, ☆ Spanish]
[E18] [2025-02-08] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - Don’t Look Down on My Guys [☆ Japanese, ☆ Korean, ☆ English, ☆ Portuguese, ☆ German, ☆ French, ☆ Castilian, ☆ Italian, ☆ Tamil (India), ☆ Hindi, ☆ Telugu (India), ☆ Spanish]
[E19] [2025-02-15] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - The 10th S-Rank Hunter [☆ Japanese, ☆ Korean, ☆ English, ☆ German, ☆ French, ☆ Telugu (India), ☆ Tamil (India), ☆ Castilian, ☆ Italian, ☆ Hindi, ☆ Spanish, ☆ Portuguese]
[E20] [2025-02-22] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - Looking Up Was Tiring Me Out [☆ Japanese, ☆ Korean, ☆ English, ☆ German, ☆ French, ☆ Castilian, ☆ Spanish, ☆ Hindi, ☆ Tamil (India), ☆ Italian, ☆ Telugu (India), ☆ Portuguese]
[E21] [2025-03-01] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - It was All Worth It [☆ Japanese, ☆ Korean, ☆ English, ☆ German, ☆ Spanish, ☆ French, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India), ☆ Castilian, ☆ Italian, ☆ Portuguese]
[E22] [2025-03-08] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - We Need a Hero [☆ Japanese, ☆ Korean, ☆ English, ☆ Italian, ☆ Spanish, ☆ French, ☆ German, ☆ Castilian, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India), ☆ Portuguese]
[E23] [2025-03-15] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - It's Going to Get Even More Intense [☆ Japanese, ☆ Korean, ☆ English, ☆ Spanish, ☆ French, ☆ German, ☆ Italian, ☆ Castilian, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India), ☆ Portuguese]
[E24] [2025-03-22] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - Are You the King of Humans [☆ Japanese, ☆ Korean, ☆ English, ☆ French, ☆ Spanish, ☆ German, ☆ Italian, ☆ Castilian, ☆ Hindi, ☆ Tamil (India), ☆ Telugu (India)]
[E25] [2025-03-29] Solo Leveling Season 2 -Arise from the Shadow- - Season 2 - On to the Next Target [☆ Japanese, ☆ Korean, ☆ English]
[S1] [2024-02-24] Solo Leveling - Season 1 - How to Get Stronger [Japanese, Korean]

------------------------------

[S1E1] - I'm Used to It [✓ Japanese]
Requesting: [G14U415QM] Solo Leveling - 1 - I'm Used to It
Chapter request successful
[ERROR] No valid Widevine or PlayReady CDM detected. Please ensure a supported and functional CDM is installed.
[ERROR] Unable to download selected episode 1

❯ $env.LAST_EXIT_CODE
0

Additional Information

I've reproduced this on both Linux and Windows. aniDL should exit with a non-zero error code (possibly 1) upon failures. See https://tldp.org/LDP/abs/html/exitcodes.html for more details.

[Jaynator495]

Uhh, I can look into this, right now we aren't explicitly terminating the application on error so it goes with the nodejs default exit code of 0, but at least in theory it shouldn't be too bad to change (just checking the return function to see if it was a success, and if not manually exist with process.exit(1) if I remember right). I could also just throw an error on fatal errors, rather than logging, but it would be less "clean"

[Ravencentric]

Thank you for considering it. I was relying on the exit code to detect failures and that's how I found out.

[HyperNylium]

Not sure if you found a work around, but i solved it by checking if the console output ever had [mkvmerge Done]. If it did, the episode probably downloaded ok (never had a case when that was outputted and the episode failed to download).

Here the full function for context:

  success = False
  with subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, text=True, bufsize=1) as proc:
      for line in proc.stdout:
          cleaned = line.rstrip()
          logger.info(f"[MDNX_API][multi-download-nx] {cleaned}")

          if "[mkvmerge Done]" in cleaned:
              success = True

  if proc.returncode != 0:
      logger.error(f"[MDNX_API] Download failed with exit code {proc.returncode}")
      return False

  if not success:
      logger.error("[MDNX_API] Download did not report successful download. Assuming failure.")
      return False

  logger.info("[MDNX_API] Download finished successfully.")
  return True

[Ravencentric]

I've been doing something similar by checking the stdout for known failure cases.