Skip to content

refactor(bazel): drop interop support for spec_bundling tooling #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

josephperrott
Copy link
Member

Remove interop support for spec_bundle tooling

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Aug 5, 2025
@josephperrott josephperrott marked this pull request as ready for review August 5, 2025 21:47
@josephperrott josephperrott marked this pull request as draft August 5, 2025 21:51
Remove interop support for spec_bundle tooling
@josephperrott josephperrott force-pushed the spec-bundling-interop branch from e418332 to d70ca03 Compare August 6, 2025 16:54
@angular-robot angular-robot bot removed the action: merge The PR is ready for merge by the caretaker label Aug 6, 2025
@josephperrott josephperrott marked this pull request as ready for review August 6, 2025 16:54
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, why do we keep the old rule?

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2025
@josephperrott
Copy link
Member Author

We keep the old rule because it is used internally within dev-infra. I am working on all of the other moving pieces of migration for within dev-infra, but this allows us to more quickly be able to drop rules_nodejs from the other repo WORKSPACE files.

@josephperrott josephperrott force-pushed the spec-bundling-interop branch from 8ff29bc to 3bdff07 Compare August 6, 2025 19:04
@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit 3bb1147.

The changes were merged into the following branches: main

@josephperrott josephperrott deleted the spec-bundling-interop branch August 6, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants