Skip to content

Potential unsound public API #40

@charlesxsh

Description

@charlesxsh

Except the issues mentioned at #37,
At src/common.rs:76

    pub fn check_len(&self, n: usize) -> bool {
        unsafe { self.ptr.add(n) <= self.end }
    }

The index does have appropriate check and passed into pointer's add, which violates the safety requirements mentioned in document

Suggestion:

  1. use self.end minus self.ptr frist

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions