Renderer: setGhostText not respecting Padding

[RickStrahl]

Describe the bug

When the editor has padding and you use editor.setGhostText() the ghost text renders at the left margin, rather than at the padded location.

Expected Behavior

Ghost text should flow in the same space as the editor text and in this case respect the padding set on the editor.

Current Behavior

see image

Reproduction Steps

see image

• Open Kitchen Sink (in Markdown mode)
• editor.renderer.setPadding(100)
• editor.setGhostText("Some long text that will wrap across multiple lines")

Possible Solution

No response

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

1.41 (latest online version)

[RickStrahl]

Looks like setting the margin on the div to match the padding may do the trick at least partially:

VirtualRenderer.prototype.setGhostText = function (text, position) {
    var cursor = this.session.selection.cursor;
    var insertPosition = position || { row: cursor.row, column: cursor.column };
    this.removeGhostText();
    var textChunks = this.$calculateWrappedTextChunks(text, insertPosition);
    this.addToken(textChunks[0].text, "ghost_text", insertPosition.row, insertPosition.column);
    this.$ghostText = {
        text: text,
        position: {
            row: insertPosition.row,
            column: insertPosition.column
        }
    };
    var widgetDiv = dom.createElement("div");

    widgetDiv.style.marginLeft = this.$padding + "px"; // <-- Fix: respect renderer padding

    if (textChunks.length > 1) {
        // ... rest of function unchanged ...
    }
};

On quick inspection this seems to work (fix per CoPilot).

There is another related issue though:

If the ghostext is injected into a non-zero position and contains multiple lines, the first line does not respect the padding. Subsequent lines however do. Setting marginRight seems to have no effect here.

I have this working by explicitly forcing the ghostext to a new line rather than continuing. That works, but is not quite natural for 'autocomplete' style scenarios.

IAC the fix above is an improvement over the way it work before the patch: