Skip to content

Commit 773dbf8

Browse files
fix: sync-users for airflow 2.7.0 (#772)
* fix: update User, Role import to support Airflow 2.7.0 Signed-off-by: Sam Wheating <[email protected]> * fix: clarify comments for each version Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Sam Wheating <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
1 parent 696e613 commit 773dbf8

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

charts/airflow/templates/sync/_helpers/sync_users.tpl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,17 @@ flask_app = www_app.create_app()
2525
flask_appbuilder = flask_app.appbuilder
2626
{{- end }}
2727

28-
# airflow uses its own incompatible FAB models in 2.3.0+
28+
# airflow moves the User and Role models around in different versions
2929
try:
30-
from airflow.www.fab_security.sqla.models import User, Role
30+
# since 2.7.0
31+
from airflow.auth.managers.fab.models import User, Role
3132
except ModuleNotFoundError:
32-
from flask_appbuilder.security.sqla.models import User, Role
33+
try:
34+
# from 2.3.0 to 2.6.3
35+
from airflow.www.fab_security.sqla.models import User, Role
36+
except ModuleNotFoundError:
37+
# before 2.3.0
38+
from flask_appbuilder.security.sqla.models import User, Role
3339

3440

3541
#############

0 commit comments

Comments
 (0)