refactor(datapath): remove dead code after proto refactors

Remove methods that have no callers after the lazy-decode and flat-bytes
proto changes:
- ProtoPublish::is_command / get_application_payload / get_command_payload
- SlimHeader::set_error_flag (duplicate of set_error)
- ProtoMessage::set_error_flag (same)
- ProtoName::name_id (redundant: id() + NULL_COMPONENT check)

Also fix minor issues:
- Redundant destructure in subscription_table remove_connection loop
- Clippy: &str passed where str suffices in session_controller verify call

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>

Author: Tehsmash

data-plane/core/datapath/src/api.rs

@@ -221,12 +221,6 @@ impl ProtoName {
         decode_name_bytes(&self.encoded_name).map_or(NULL_COMPONENT, |(_, _, _, id)| id)
     }
 
-    /// Returns the ID as an `Option<u128>` — `None` when the ID is `NULL_COMPONENT`.
-    pub fn name_id(&self) -> Option<u128> {
-        let id = self.id();
-        if id == NULL_COMPONENT { None } else { Some(id) }
-    }
-
     /// Returns the ID as a human-readable string.
     pub fn string_id(&self) -> String {
         id_to_string(self.id())

data-plane/core/datapath/src/messages/utils.rs

@@ -391,10 +391,6 @@ impl SlimHeader {
         self.incoming_conn = incoming_conn;
     }
 
-    pub fn set_error_flag(&mut self, error: Option<bool>) {
-        self.error = error;
-    }
-
     pub fn get_ttl(&self) -> u32 {
         self.ttl
     }
@@ -590,42 +586,6 @@ impl ProtoPublish {
         self.msg = payload.encode_to_vec().into();
     }
 
-    pub fn is_command(&self) -> bool {
-        match self
-            .get_payload()
-            .expect("msg must be set")
-            .content_type
-            .as_ref()
-            .unwrap()
-        {
-            ContentType::AppPayload(_) => false,
-            ContentType::CommandPayload(_) => true,
-        }
-    }
-
-    pub fn get_application_payload(&self) -> ApplicationPayload {
-        match self
-            .get_payload()
-            .expect("msg must be set")
-            .content_type
-            .unwrap()
-        {
-            ContentType::AppPayload(application_payload) => application_payload,
-            ContentType::CommandPayload(_) => panic!("the payload is not an application payload"),
-        }
-    }
-
-    pub fn get_command_payload(&self) -> CommandPayload {
-        match self
-            .get_payload()
-            .expect("msg must be set")
-            .content_type
-            .unwrap()
-        {
-            ContentType::AppPayload(_) => panic!("the payload is not a command payload"),
-            ContentType::CommandPayload(command_payload) => command_payload,
-        }
-    }
 }
 
 /// From ProtoMessage to ProtoPublish
@@ -926,10 +886,6 @@ impl ProtoMessage {
         self.get_slim_header_mut().set_incoming_conn(incoming_conn);
     }
 
-    pub fn set_error_flag(&mut self, error: Option<bool>) {
-        self.get_slim_header_mut().set_error_flag(error);
-    }
-
     pub fn get_ttl(&self) -> u32 {
         self.get_slim_header().get_ttl()
     }

data-plane/core/datapath/src/tables/subscription_table.rs

@@ -644,8 +644,7 @@ impl SubscriptionTable for SubscriptionTableImpl {
         // Pass 2: clone snapshot, remove conn from routing for every affected encoded name.
         let mut rs = (**current).clone();
         drop(current);
-        for (prefix, id) in &encoded_names {
-            let (prefix, id) = (*prefix, *id);
+        for &(prefix, id) in &encoded_names {
             debug!(%conn, ?prefix, id, "remove subscription");
 
             let should_remove_prefix = if let Some(entry) = rs.get_mut(&prefix) {

data-plane/core/session/src/session_controller.rs

@@ -37,8 +37,8 @@ where
     V: Verifier + Send + Sync,
 {
     let identity = msg.get_slim_header().get_identity();
-    if verifier.try_verify(&identity).is_err() {
-        verifier.verify(&identity).await?;
+    if verifier.try_verify(identity).is_err() {
+        verifier.verify(identity).await?;
     }
     Ok(())
 }