CJM-97211 Introduce xdm-schema for message-rendering-context dataset #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandphatak
reviewed
May 30, 2025
| "type": "object", | ||
| "title": "Message Details", | ||
| "description": "Contains the specific content details for the message, varying by channel (e.g., email or SMS).", | ||
| "oneOf": [ |
There was a problem hiding this comment.
I am not sure if oneOf will work. What are you expecting the validator to validate?
| "title": "Message Details", | ||
| "description": "Contains the specific content details for the message, varying by channel (e.g., email or SMS).", | ||
| "oneOf": [ | ||
| { |
There was a problem hiding this comment.
The structure of this JSON schema does not look right.
|
@anandphatak Would you please take a look at this PR? |
|
@himanshi2010 there are still some issues with the PR. My comments above for "allOf" are not addressed. Please setup a meeting to discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new field group schemas for Message Rendered Content, Rendering Metadata and Delivery Metadata of the communications going out of the AJO to provide the message-export functionality to the customers.
Wiki: https://wiki.corp.adobe.com/display/CJM/Message+Export+in+AJO