DSL for Parse::Query#in_query

[adelevie]

Here's the current usage:

Assume I have the classes Post, Tags, and PostTags (which joins the first two).
def in_query(field, query)
query_hash = {Parse::Protocol::KEY_CLASS_NAME => query.class_name, "where" => query.where}
add_constraint(field, "$inQuery" => query_hash)
self
end

post_tags = Parse::Query.new("PostTag").tap do |q|
  q.in_query("tag", Parse::Query.new("Tag").tap do |tq|
    tq.eq("category", "Person")
  end)
end.get

And here's what I propose:

post_tags = Parse::Query.new("PostTag").tap do |q|
  q.in_query("tag") do |tag_query|
    tag_query.eq("category", "Person")
  end
end.get

Is this something anyone (@ericcj, @jamonholmgren) would want?

[jamonholmgren]

I haven't had a need for "$inQuery" yet but this looks cleaner. 👍 if you want to make it happen.

[adelevie]

Maybe I'll save that nice syntax for the parse_resource-ruby-client-epic-merge.

[jamonholmgren]

We should do a parse_resource-ruby-client-epic-merge hackathon.

[ericcj]

it's nice to get rid of the new'ing of queries everywhere, but you have to
somehow infer that the "tag" column refers to the "Tag" class. that seems
like a reasonable convention, and indeed we use the below in our app to
provide it, but it's not inherently part of the parse api.

def class_name_for_column(column)
column == 'user' ? Parse::Protocol::CLASS_USER : column.camelize
end

def column_name_for_class(clazz)
clazz == Parse::Protocol::CLASS_USER ? 'user' : clazz.camelize(:lower)
end

On Fri, Jan 11, 2013 at 11:54 AM, Jamon Holmgren
notifications@github.comwrote:

I haven't had a need for "$inQuery" yet but this looks cleaner. [image:
👍] if you want to make it happen.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-12152840.

[adelevie]

That does look pretty useful.

Also, perhaps a simpler implementation is to not use blocks, and instead to have #in_query return an instance of Parse::Query. Then just call #tap against the new query object to build and add parameters:

post_tags = Parse::Query.new("PostTag").tap do |q|
  q.in_query("tag").tap |tag_query|
    tag_query.eq("category", "Person")
  end
end.get

[adelevie]

@jamonholmgren heh, maybe a (mandatory) Clearsight Studio employee hackathon. I'll just kick back and accept the pull requests.

[jamonholmgren]

@adelevie there you go, open source administration at its best.