STK: Snapshot 11-14-25 06:22 from Sierra 5.27.3-195-g383cb9a3

Signed-off-by: Alan Williams <[email protected]>

Author: alanw0

packages/stk/CHANGELOG.md

@@ -1,5 +1,12 @@
 # CHANGELOG
 
+5.27.2-02    (STK_VERSION 5270202) 11/14/25
+  stk_util: deprecate STK_FUNCTION/STK_INLINE_FUNCTION; prefer direct usage
+            of KOKKOS_FUNCTION/KOKKOS_INLINE_FUNCTION
+  stk_mesh: Change default access tag for Field::data<>() to ReadOnly.
+            Also misc bug fixes related to shell-edge connectivity,
+            multi-state field initialization, etc.
+
 5.27.2-01    (STK_VERSION 5270201) 11/05/25
   stk_doc_tests: fix build error when Seacas/Ioss is on but MPI is off
   stk_mesh: add GPU-compatible APIs for parallel_sum and friends.

packages/stk/stk_balance/stk_balance/balanceUtils.cpp

@@ -54,7 +54,7 @@ double BalanceSettings::getFieldVertexWeight(const stk::mesh::BulkData &bulkData
 {
     const stk::mesh::Field<double> &field = *getVertexWeightField(bulkData, criteria_index);
     if (field.defined_on(entity)) {
-      auto fieldData = field.data<stk::mesh::ReadOnly>();
+      auto fieldData = field.data();
       auto weight = fieldData.entity_values(entity);
       STK_ThrowRequireWithSierraHelpMsg(weight() >= 0);
       return weight();

packages/stk/stk_balance/stk_balance/internal/Vertices.cpp

@@ -47,7 +47,7 @@ void Vertices::fillVertexWeights(const stk::mesh::BulkData& bulkData,
   }
   else if (balanceSettings.getVertexWeightMethod() == VertexWeightMethod::CONNECTIVITY) {
     const stk::mesh::Field<double> & connectivityWeights = *balanceSettings.getVertexConnectivityWeightField(bulkData);
-    auto connectivityWeightsData = connectivityWeights.data<stk::mesh::ReadOnly>();
+    auto connectivityWeightsData = connectivityWeights.data();
     for (size_t i = 0; i < entities.size(); ++i) {
       mVertexWeights[i] = connectivityWeightsData.entity_values(entities[i])();
     }

packages/stk/stk_balance/stk_balance/internal/Zoltan2ParallelGraph.cpp

@@ -345,7 +345,7 @@ void Zoltan2ParallelGraph::createGraphEdgesUsingNodeConnectivity(stk::mesh::Bulk
         }
         else if (balanceSettings.getVertexWeightMethod() == stk::balance::VertexWeightMethod::CONNECTIVITY) {
           const stk::mesh::Field<double> & connectivityWeights = *balanceSettings.getVertexConnectivityWeightField(stkMeshBulkData);
-          auto connectivityWeightsData = connectivityWeights.data<stk::mesh::ReadOnly>();
+          auto connectivityWeightsData = connectivityWeights.data();
           mVertexWeights[local_id] = connectivityWeightsData.entity_values(elementOfConcern)();
         }
         else if (balanceSettings.getVertexWeightMethod() == stk::balance::VertexWeightMethod::FIELD) {

packages/stk/stk_balance/stk_balance/internal/privateDeclarations.cpp

@@ -8,7 +8,6 @@
 #include <stk_balance/internal/DiagnosticsContainer.hpp>
 
 #include <stk_mesh/base/MetaData.hpp>
-#include <stk_mesh/base/SkinMesh.hpp>
 #include <stk_mesh/base/FieldBase.hpp>  // for field_data
 #include <stk_mesh/base/FieldBLAS.hpp>
 #include <stk_mesh/base/GetEntities.hpp>
@@ -35,7 +34,6 @@
 #include "stk_mesh/base/FieldParallel.hpp"
 #include <stk_mesh/base/SideSetEntry.hpp>
 #include <stk_mesh/base/SkinBoundary.hpp>
-#include <stk_mesh/base/SkinMeshUtil.hpp>
 #include <stk_util/environment/Env.hpp>
 #include <stk_util/parallel/ParallelReduce.hpp>
 #include <stk_util/parallel/OutputStreams.hpp>
@@ -769,7 +767,7 @@ void fill_spider_connectivity_count_fields_and_parts(stk::mesh::BulkData & bulk,
 
 
   const stk::mesh::Field<int> * volumeConnectivityCountField = balanceSettings.getSpiderVolumeConnectivityCountField(bulk);
-  auto volumeConnectivityCountFieldData = volumeConnectivityCountField->data();
+  auto volumeConnectivityCountFieldData = volumeConnectivityCountField->data<stk::mesh::ReadWrite>();
   stk::mesh::Selector selectBeamElements(meta.locally_owned_part() &
                                          meta.get_topology_root_part(stk::topology::BEAM_2));
   stk::mesh::EntityVector beams;
@@ -787,7 +785,7 @@ void fill_output_subdomain_field(const stk::mesh::BulkData & bulk, const Balance
 {
   if (balanceSettings.shouldFixSpiders()) {
     const stk::mesh::Field<int> * outputSubdomainField = balanceSettings.getOutputSubdomainField(bulk);
-    auto outputSubdomainFieldData = outputSubdomainField->data();
+    auto outputSubdomainFieldData = outputSubdomainField->data<stk::mesh::ReadWrite>();
 
     for (const stk::mesh::EntityProc & entityProc : decomp) {
       const stk::mesh::Entity elem = entityProc.first;
@@ -859,7 +857,7 @@ void store_diagnostic_element_weights(const stk::mesh::BulkData & bulk,
 {
   if (stk::balance::get_diagnostic<TotalElementWeightDiagnostic>()) {
     const stk::mesh::Field<double> & weightField = *balanceSettings.getDiagnosticElementWeightField(bulk);
-    auto weightFieldData = weightField.data();
+    auto weightFieldData = weightField.data<stk::mesh::ReadWrite>();
     const std::vector<double> & vertexWeights = vertices.get_vertex_weights();
     const int numSelectors = 1;
     const int selectorIndex = 0;
@@ -1043,7 +1041,7 @@ std::pair<stk::mesh::Entity, stk::mesh::Entity> get_spider_beam_body_and_node_fo
   const stk::mesh::Entity * elems = bulk.begin_elements(bodyNode);
   const unsigned numElements = bulk.num_elements(bodyNode);
   const stk::mesh::Field<int> & volumeElemConnectivityCountField = *balanceSettings.getSpiderVolumeConnectivityCountField(bulk);
-  auto volumeElemConnectivityCountFieldData = volumeElemConnectivityCountField.data<stk::mesh::ReadOnly>();
+  auto volumeElemConnectivityCountFieldData = volumeElemConnectivityCountField.data();
 
   for (unsigned i = 0; i < numElements; ++i) {
     if (bulk.bucket(elems[i]).topology() == stk::topology::BEAM_2) {
@@ -1149,7 +1147,7 @@ stk::mesh::EntityVector get_local_spider_legs(const stk::mesh::BulkData & bulk,
 int get_new_spider_leg_owner(const stk::mesh::BulkData & bulk, const stk::mesh::Entity & footNode,
                              const stk::mesh::Part & spiderPart, const stk::mesh::Field<int> & outputSubdomainField)
 {
-  auto outputSubdomainFieldData = outputSubdomainField.data<stk::mesh::ReadOnly>();
+  auto outputSubdomainFieldData = outputSubdomainField.data();
   const stk::mesh::Entity* footElements = bulk.begin_elements(footNode);
   const unsigned numElements = bulk.num_elements(footNode);
   int newLegOwner = std::numeric_limits<int>::max();
@@ -1196,7 +1194,7 @@ void update_output_subdomain_field(const stk::mesh::BulkData & bulk,
                                    stk::mesh::Entity spiderEntity,
                                    int newLegOwner)
 {
-  auto outputSubdomainFieldData = outputSubdomainField.data();
+  auto outputSubdomainFieldData = outputSubdomainField.data<stk::mesh::ReadWrite>();
   if (bulk.entity_rank(spiderEntity) == stk::topology::ELEM_RANK) {
     auto outputSubdomain = outputSubdomainFieldData.entity_values(spiderEntity);
     outputSubdomain() = newLegOwner;
@@ -1493,7 +1491,7 @@ void compute_total_element_weight_diagnostic(TotalElementWeightDiagnostic & diag
                                              const stk::balance::BalanceSettings & balanceSettings,
                                              const stk::mesh::Field<double> & weightField, int rank)
 {
-  auto weightFieldData = weightField.data<stk::mesh::ReadOnly>();
+  auto weightFieldData = weightField.data();
   const stk::mesh::BucketVector & buckets = bulk.get_buckets(stk::topology::ELEM_RANK,
                                                              bulk.mesh_meta_data().locally_owned_part());
   const int numCriteria = balanceSettings.getNumCriteria();
@@ -1635,7 +1633,7 @@ double get_connected_node_weight(const stk::mesh::BulkData & bulk, std::vector<s
 void spread_weight_across_connected_elements(const stk::mesh::BulkData & bulk, const stk::mesh::Entity & node,
                                              double nodeWeight, const stk::mesh::Field<double> & elementWeights)
 {
-  auto elementWeightsData = elementWeights.data();
+  auto elementWeightsData = elementWeights.data<stk::mesh::ReadWrite>();
   const unsigned numElements = bulk.num_elements(node);
   const stk::mesh::Entity * elements = bulk.begin_elements(node);
 
@@ -1677,7 +1675,7 @@ void compute_connectivity_weight_diagnostic(ConnectivityWeightDiagnostic & diag,
 {
   const stk::mesh::MetaData & meta = bulk.mesh_meta_data();
   const stk::mesh::Field<double> & elementWeights = *balanceSettings.getVertexConnectivityWeightField(bulk);
-  auto elementWeightsData = elementWeights.data<stk::mesh::ReadOnly>();
+  auto elementWeightsData = elementWeights.data();
 
   double totalWeight = 0.0;
   const stk::mesh::BucketVector & buckets = bulk.get_buckets(stk::topology::ELEM_RANK, meta.locally_owned_part());

packages/stk/stk_doc_tests/stk_balance/howToUseStkBalance.cpp

@@ -39,7 +39,7 @@ bool is_mesh_balanced(const stk::mesh::BulkData& bulk)
 
 bool is_mesh_balanced_wrt_weight(const stk::mesh::BulkData& bulk, stk::mesh::Field<double>& weightField)
 {
-    auto weightFieldData = weightField.data<stk::mesh::ReadOnly>();
+    auto weightFieldData = weightField.data();
 
     std::vector<size_t> counts;
     stk::mesh::comm_mesh_counts(bulk, counts);
@@ -246,7 +246,7 @@ class FieldVertexWeightSettings : public stk::balance::GraphCreationSettings
 
 void set_vertex_weights(const stk::mesh::BulkData& bulk, stk::mesh::Selector selector, stk::mesh::Field<double>& weightField)
 {
-    auto weightFieldData = weightField.data();
+    auto weightFieldData = weightField.data<stk::mesh::ReadWrite>();
 
     stk::mesh::EntityVector elements;
     stk::mesh::get_entities(bulk, stk::topology::ELEM_RANK, selector, elements);
@@ -406,8 +406,8 @@ void set_vertex_weights_checkerboard(stk::mesh::BulkData& bulk, stk::mesh::Selec
     stk::mesh::EntityVector elements;
     stk::mesh::get_entities(bulk, stk::topology::ELEM_RANK, selector, elements);
 
-    auto weightField1Data = weightField1.data();
-    auto weightField2Data = weightField2.data();
+    auto weightField1Data = weightField1.data<stk::mesh::ReadWrite>();
+    auto weightField2Data = weightField2.data<stk::mesh::ReadWrite>();
     for(stk::mesh::Entity element : elements)
     {
         auto data1 = weightField1Data.entity_values(element);

packages/stk/stk_doc_tests/stk_io/RenamedInputFields.cpp

@@ -74,7 +74,7 @@ class InputNodesetDataCalledDispX : public stk::unit_test_util::MeshFixture
   void expect_field_data(stk::mesh::FieldBase *field, double expected)
   {
     stk::mesh::Entity node11 = get_bulk().get_entity(stk::topology::NODE_RANK, 11);
-    auto fieldData = field->data<double,stk::mesh::ReadOnly>();
+    auto fieldData = field->data<double>();
     ASSERT_TRUE(field->defined_on(node11));
     auto nodeData = fieldData.entity_values(node11);
     const double epsilon = 1e-6;

packages/stk/stk_doc_tests/stk_io/handleMissingFieldOnRead.cpp

@@ -144,7 +144,7 @@ namespace {
       EXPECT_EQ("disp", missing_fields[1].db_name());
       EXPECT_EQ("displacement_STKFS_N", missing_fields[1].field()->name());
 
-      auto temperatureData = temperature.data<stk::mesh::ReadOnly>();
+      auto temperatureData = temperature.data();
 
       // The value of the "temperature" field at all nodes should be 2.0
       stk::mesh::for_each_entity_run(stkIo.bulk_data(), stk::topology::NODE_RANK,

packages/stk/stk_doc_tests/stk_io/howToCreateAndWriteNodesetOrSideset.cpp

@@ -76,8 +76,8 @@ void compare_fields(const stk::mesh::BulkData& bulk1,
 
   ASSERT_EQ(entityList1.size(), entityList2.size());
 
-  auto field1Data = field1->data<double,stk::mesh::ReadOnly>();
-  auto field2Data = field2->data<double,stk::mesh::ReadOnly>();
+  auto field1Data = field1->data<double>();
+  auto field2Data = field2->data<double>();
 
   for(unsigned i=0; i<entityList1.size(); ++i)
   {
@@ -105,7 +105,7 @@ void verify_field_is_valid(const stk::mesh::MetaData &meta,
   stk::topology::rank_t rank = meta.mesh_bulk_data().entity_rank(entity);
   stk::mesh::FieldBase* field = meta.get_field(rank, fieldName);
   ASSERT_TRUE(field != nullptr);
-  auto fieldData = field->data<double,stk::mesh::ReadOnly>();
+  auto fieldData = field->data<double>();
   auto fieldDataForEntity = fieldData.entity_values(entity);
   const unsigned numComponents = fieldDataForEntity.num_components();
   ASSERT_EQ(fieldLength, numComponents);

packages/stk/stk_doc_tests/stk_io/howToWriteRestartWithEdges.cpp

@@ -67,7 +67,7 @@ TEST(StkIoHowTo, WriteRestartWithEdges)
     stk::mesh::EntityVector edges;
     stk::mesh::get_entities(*bulk, stk::topology::EDGE_RANK, edges);
 
-    auto edgeFieldData = edgeField.data<stk::mesh::ReadOnly>();
+    auto edgeFieldData = edgeField.data();
 
     for(auto edge : edges) {
       auto data = edgeFieldData.entity_values(edge);