Skip to content

Commit baa03d2

Browse files
authored
Merge pull request #23 from Anshukumar123975/main
feat(ci/cd): Updated readme and modified some skip tags within feature files
2 parents 8abb23f + 1fe7d1a commit baa03d2

25 files changed

+109
-97
lines changed

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,25 @@ This repository includes:
88
1. A set of semantic validation rules
99
2. Comprehensive valid and invalid model examples
1010
3. Tests written using Cucumber, offering behavior-driven, human-readable test definitions
11-
4. Support for both JavaScript and C# runtimes
11+
4. Support for both JavaScript, C#(partially) and Rust runtimes.
1212
The suite specifically tests core components of the Concerto ecosystem: the `ModelFile` and `ModelManager` classes from `@accordproject/concerto-core`
1313

14+
## Working:
15+
This test suite enables straightforward integration with CI/CD pipelines, so Concerto itself can:
16+
1. Automatically run conformance tests on every push
17+
2. Detect semantic rule violations or model-breaking changes early
18+
3. Maintain consistent validation standards across development workflows
19+
1420
## Getting started
1521
1. Install dependencies:
1622
`npm install`
1723
2. Run the Javascript test suite:
1824
`npm test`
1925
3. Run tests for C#:
2026
`npm run test:csharp`
27+
4. Running tests for Rust can be done through the concerto-rust repository.
2128

2229
## Interactive CLI:
2330
You can also use the built-in CLI for a guided setup:
2431
`npm start`
25-
The CLI allows you to provide custom ModelManager, Parser, or ModelFile sources for testing.
26-
27-
## Future Roadmap
28-
Enabling straightforward integration with CI/CD pipelines, so projects like Concerto itself can:
29-
1. Automatically run conformance tests on every push
30-
2. Detect semantic rule violations or model-breaking changes early
31-
3. Maintain consistent validation standards across development workflows
32+
The CLI allows you to provide custom ModelManager, Parser, or ModelFile sources for testing.

semantic/features/imports.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Feature: Semantic Validation of CTO Model Imports
2525
When I validate the models
2626
Then no error should be thrown
2727

28+
2829
Scenario: Importing a non-existent type should throw an error
2930
Given I load the following models:
3031
| model_file | alias |

semantic/features/namespaces.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Feature: Semantic Validation of CTO Namespace Imports
1717
When I validate the models
1818
Then no error should be thrown
1919

20+
@skip
2021
Scenario: Invalid self-import should throw MODEL_FILE_003 error
2122
Given I load the following models:
2223
| model_file | alias |

semantic/features/scalars.feature

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,5 @@ Feature: Semantic Validation of CTO Scalars specification
8383
Given I load the following models:
8484
| model_file |alias|
8585
| scalars/models/STRING_VALIDATOR_004/string_validator_004_invalid_regex.json |main|
86-
Then an error should be thrown with message ""
86+
Then an error should be thrown with message ""
87+

semantic/features/support/C#/Semantic.Support.CSharp/obj/Debug/net6.0/Semantic.Support.CSharp.AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
[assembly: System.Reflection.AssemblyCompanyAttribute("Semantic.Support.CSharp")]
1414
[assembly: System.Reflection.AssemblyConfigurationAttribute("Debug")]
1515
[assembly: System.Reflection.AssemblyFileVersionAttribute("1.0.0.0")]
16-
[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+354edac614ff1cc5734e091c9f2ab5f843b81f70")]
16+
[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.0.0+8b3d188f7796bc86a769ec0ca9b44e179af46cb7")]
1717
[assembly: System.Reflection.AssemblyProductAttribute("Semantic.Support.CSharp")]
1818
[assembly: System.Reflection.AssemblyTitleAttribute("Semantic.Support.CSharp")]
1919
[assembly: System.Reflection.AssemblyVersionAttribute("1.0.0.0")]
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
121101efc7250796187da6fd13d84572e2ffed7b0f31d6bb945127d6b01999a3
1+
d4c49a2cbffa6f0bfb0fb1db59ac11c770e8933624109920ba2eaa13a42b389d

semantic/features/support/Javascript/world.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export class CustomWorld {
1212
async initialize() {
1313
const deps = await loadDependencies();
1414
const ModelManager = deps.ModelManager;
15-
this.modelManager = new ModelManager({ enableMapType: true });
15+
this.modelManager = new ModelManager({ strict: true, importAliasing: true, enableMapType: true });
1616
}
1717
}
1818

semantic/specifications/concepts/models/CLASS_DECLARATION_009/class_declaration_009_circular_inheritance.cto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace org.invalid.circular
1+
namespace org.invalid.circular@1.0.0
22

33
concept A extends C {
44
o String name

semantic/specifications/concepts/models/CLASS_DECLARATION_009/class_declaration_009_circular_inheritance.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"$class": "[email protected]",
33
"decorators": [],
4-
"namespace": "org.invalid.circular",
4+
"namespace": "org.invalid.circular@1.0.0",
55
"imports": [],
66
"declarations": [
77
{
@@ -17,13 +17,13 @@
1717
"location": {
1818
"$class": "[email protected]",
1919
"start": {
20-
"offset": 59,
20+
"offset": 65,
2121
"line": 4,
2222
"column": 3,
2323
"$class": "[email protected]"
2424
},
2525
"end": {
26-
"offset": 74,
26+
"offset": 80,
2727
"line": 5,
2828
"column": 1,
2929
"$class": "[email protected]"
@@ -34,13 +34,13 @@
3434
"location": {
3535
"$class": "[email protected]",
3636
"start": {
37-
"offset": 34,
37+
"offset": 40,
3838
"line": 3,
3939
"column": 1,
4040
"$class": "[email protected]"
4141
},
4242
"end": {
43-
"offset": 75,
43+
"offset": 81,
4444
"line": 5,
4545
"column": 2,
4646
"$class": "[email protected]"
@@ -64,13 +64,13 @@
6464
"location": {
6565
"$class": "[email protected]",
6666
"start": {
67-
"offset": 104,
67+
"offset": 110,
6868
"line": 8,
6969
"column": 3,
7070
"$class": "[email protected]"
7171
},
7272
"end": {
73-
"offset": 126,
73+
"offset": 132,
7474
"line": 9,
7575
"column": 1,
7676
"$class": "[email protected]"
@@ -81,13 +81,13 @@
8181
"location": {
8282
"$class": "[email protected]",
8383
"start": {
84-
"offset": 79,
84+
"offset": 85,
8585
"line": 7,
8686
"column": 1,
8787
"$class": "[email protected]"
8888
},
8989
"end": {
90-
"offset": 127,
90+
"offset": 133,
9191
"line": 9,
9292
"column": 2,
9393
"$class": "[email protected]"
@@ -111,13 +111,13 @@
111111
"location": {
112112
"$class": "[email protected]",
113113
"start": {
114-
"offset": 156,
114+
"offset": 162,
115115
"line": 12,
116116
"column": 3,
117117
"$class": "[email protected]"
118118
},
119119
"end": {
120-
"offset": 173,
120+
"offset": 179,
121121
"line": 13,
122122
"column": 1,
123123
"$class": "[email protected]"
@@ -128,13 +128,13 @@
128128
"location": {
129129
"$class": "[email protected]",
130130
"start": {
131-
"offset": 131,
131+
"offset": 137,
132132
"line": 11,
133133
"column": 1,
134134
"$class": "[email protected]"
135135
},
136136
"end": {
137-
"offset": 174,
137+
"offset": 180,
138138
"line": 13,
139139
"column": 2,
140140
"$class": "[email protected]"

semantic/specifications/concepts/models/CLASS_DECLARATION_009/class_declaration_009_valid_inheritance.cto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
namespace org.valid.circular
1+
namespace org.valid.circular@1.0.0
22

33
concept A {
44
o String name

0 commit comments

Comments
 (0)