Unable to compile CSharp code with models containing reserved keywords

[ragi-dayananda]

Context

The generated C# code cannot be compiled when models contain any reserved .NET keywords.
Eg, 'fixed', 'void', 'event', 'virtual' etc.. https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/

enum invoice_amount_type {
   o fixed
   o maximum
}

enum issuing_card_type {
   o physical
   o virtual
}

enum invoice_status {
   o deleted
   o draft
   o open
   o paid
   o uncollectible
   o void
}

Expected Behavior

Any generated csharp code should be compilable.

Possible Fix

We can add a trailing underscore char to the reserved keyword.

Steps to Reproduce

Generate cshar code for any of the model provided in the above example. Add the generated models to any csharp project and try t build the project.

Your Environment

• Version used: 3.11.1
• Operating System and version (desktop or mobile): windows 11 desktop

[dselman]

We've various escaping functions implemented for the different code gen target languages. It would be great to have a generic function that all targets could use that was configured with a list of reserved key words / identifier syntax so we can remove some of this duplication and improve quality.

[dselman]

We've various escaping functions implemented for the different code gen target languages. It would be great to have a generic function that all targets could use that was configured with a list of reserved key words / identifier syntax so we can remove some of this duplication and improve quality.

[subhajit20]

hey @dselman it already has a function called toCSharpIdentifier which detect if the keyword is reserved.
@dselman Am I right?

[apoorvsxna]

Hey there @ragi-dayananda @dselman . Just looked through the csharpvisitor.js file and found that the suggested fix is already implemented.

I think the model being used in the issue example has incorrect syntax. Models should include a namespace declaration at the beginning, which is absent in the example.

On adding a namespace decalaration to the given model,

namespace org.example

enum invoice_amount_type {
   o fixed
   o maximum
}

enum issuing_card_type {
   o physical
   o virtual
}

enum invoice_status {
   o deleted
   o draft
   o open
   o paid
   o uncollectible
   o void
}

concept YourConcept {
  o String myField
}

it compiles just fine.