trigger should be POST not GET

[niallroche]

should agreement trigger be POST not GET to allow for idempotent trigger operations?

Bug Report 🐛

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Context (Environment)

Desktop

• OS: [e.g. macOS]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 0.22.15]

Detailed Description

Possible Implementation

[akshatbatra]

I'm a newbie to this repo, so following comes from my limited understanding of what's happening here:

Idempotency would probably depend on the logic that is being triggered, if not done right, GET or POST may not even matter, correct me if I'm wrong.

The request body is already expected and being processed in the trigger route and is sent to the JS Evaluator. However, as you've pointed out, the method is GET not POST.

HTTP spec doesn't endorse the idea of sending body in a GET request. However, it still works in a number of frameworks.

Out of curiosity, I tried to send a GET request with body via Chrome browser to an Express server that I created for testing, the browser doesn't even send the request to the server and returns the following error:

{
  "error": "Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body."
}

However, I tried to send the same GET request with body via Python requests module and it worked. The Express server was able to parse the request body as it would have in a POST request. So, from a functionality perspective, as long as the user is not sending the request via a web based user interface, the behavior is already similar to a POST request.

Nonetheless, I believe that it is better to adhere to the HTTP spec and change the method to POST. Body handling is already there so all that needs to be done is to replace crudRouter.get with crudRouter.post.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[techieadi4703]

Can u please assign this issue to me? @niallroche @dselman @tbrooke @ekarademir

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.