Merge pull request #241 from iamhoonse/fix-skip-failure-with-junit-reporter

abhinaba-ghosh · web-flow · commit e159b8816943 · 2025-08-25T17:58:40.000+05:30
checkA11y - `skipFailure` options not working when reporter is 'junit'
diff --git a/src/index.ts b/src/index.ts
@@ -160,10 +160,10 @@ export const checkA11y = async (
     reporterWithOptions = reporter
   }
 
-  if (reporter !== 'html')
+  if (reporter !== 'html' && reporter !== 'junit')
     await reportViolations(impactedViolations, reporterWithOptions)
 
-  if (reporter === 'v2' || (reporter !== 'html' && reporter !== 'junit'))
+  if (reporter === 'v2' || (reporter !== 'html'))
     testResultDependsOnViolations(impactedViolations, skipFailures)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -160,10 +160,10 @@ export const checkA11y = async (`
`160`	`160`	`reporterWithOptions = reporter`
`161`	`161`	`}`
`162`	`162`
`163`		`- if (reporter !== 'html')`
	`163`	`+ if (reporter !== 'html' && reporter !== 'junit')`
`164`	`164`	`await reportViolations(impactedViolations, reporterWithOptions)`
`165`	`165`
`166`		`- if (reporter === 'v2' \|\| (reporter !== 'html' && reporter !== 'junit'))`
	`166`	`+ if (reporter === 'v2' \|\| (reporter !== 'html'))`
`167`	`167`	`testResultDependsOnViolations(impactedViolations, skipFailures)`
`168`	`168`	`}`
`169`	`169`