Skip to content

Commit 5683f56

Browse files
authored
Merge pull request #16 from abhi1693/dev
Fixed firefox install path for windows
2 parents 12af32f + 236b56c commit 5683f56

File tree

4 files changed

+17
-2
lines changed

4 files changed

+17
-2
lines changed

.github/workflows/build-firefox.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ jobs:
1717
matrix:
1818
version: [latest, latest-devedition, latest-beta, latest-esr]
1919
os: [ubuntu, windows, macos]
20+
exclude:
21+
- os: macos
22+
version: latest-devedition
2023
runs-on: ${{ matrix.os }}-latest
2124
steps:
2225
- uses: actions/checkout@v2
@@ -44,3 +47,5 @@ jobs:
4447
version: ${{ matrix.version }}
4548
- if: runner.os != 'Windows'
4649
run: ${{ steps.browser.outputs.binary }} --version
50+
- if: runner.os == 'Windows'
51+
run: (Get-Item (Get-Command "${{ steps.browser.outputs.path }}\${{ steps.browser.outputs.binary }}").Source).VersionInfo.ProductVersion

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
# Changelog
22

3+
## [v0.3.0](https://github.com/abhi1693/setup-browser/tree/v0.3.0) (2022-02-21)
4+
5+
[Full Changelog](https://github.com/abhi1693/setup-browser/compare/v0.2.0...v0.3.0)
6+
7+
**Merged pull requests:**
8+
9+
- Added firefox for macos [\#15](https://github.com/abhi1693/setup-browser/pull/15) ([abhi1693](https://github.com/abhi1693))
10+
- Updated packages [\#14](https://github.com/abhi1693/setup-browser/pull/14) ([abhi1693](https://github.com/abhi1693))
11+
- Added firefox for windows [\#13](https://github.com/abhi1693/setup-browser/pull/13) ([abhi1693](https://github.com/abhi1693))
12+
313
## [v0.2.0](https://github.com/abhi1693/setup-browser/tree/v0.2.0) (2022-02-21)
414

515
[Full Changelog](https://github.com/abhi1693/setup-browser/compare/v0.1.1...v0.2.0)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "setup-browser",
3-
"version": "0.3.0",
3+
"version": "0.3.1",
44
"description": "Set up your GitHub Actions workflow with a specific version of browser",
55
"main": "dist/index.js",
66
"scripts": {

src/firefox/installerFactory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class WindowsInstaller implements InstallerFactory {
8888
}
8989
await exec.exec(archive, [
9090
"/S",
91-
`/InstallDirectoryName=${this.rootDir(version)}`,
91+
`/InstallDirectoryName=Firefox_${version}`,
9292
]);
9393
core.info(`Successfully install firefox to ${this.rootDir(version)}`);
9494

0 commit comments

Comments
 (0)