fix(api): wire task controls and sidebar-targeted configuration

Ports the vps2 CS API wiring onto the F4 head 80c147f:

- startNewTask(newTab, preserveOpenTabs): skips editor revert/close-all
  when preserveOpenTabs is set
- task ask registry: approveTaskAsk + selectTaskFollowupSuggestion
  (per-provider mode validation; a failed mode switch does not swallow
  the follow-up answer; a stale instance's teardown cannot evict its
  replacement)
- setConfiguration routes through ClineProvider.setValues so the
  view-local subset stays in sync with the sidebar view's state
- getConfiguration flattens the nested view-local apiConfiguration and
  strips secrets before returning
- getGlobalState read surface (test-only)
- docs: setConfiguration JSDoc now states writes target the
  extension-host (sidebar) view (parked A4 major, documented
  limitation); @PARAM note added for preserveOpenTabs
- specs: api-task-control (12 tests), api-set-configuration (1),
  api-configuration getConfiguration flatten/strip-secrets (1)

Upstream: #982 (vps2 F5)

Author: easonliang28

packages/types/src/api.ts

@@ -2,7 +2,7 @@ import type { EventEmitter } from "events"
 import type { Socket } from "net"
 
 import type { RooCodeEvents } from "./events.js"
-import type { RooCodeSettings } from "./global-settings.js"
+import type { GlobalState, RooCodeSettings } from "./global-settings.js"
 import type { HistoryItem } from "./history.js"
 import type { ProviderSettingsEntry, ProviderSettings } from "./provider-settings.js"
 import type { IpcMessage, IpcServerEvents } from "./ipc.js"
@@ -21,18 +21,21 @@ export interface RooCodeAPI extends EventEmitter<RooCodeAPIEvents> {
 	 * Starts a new task with an optional initial message and images.
 	 * @param task Optional initial task message.
 	 * @param images Optional array of image data URIs (e.g., "data:image/webp;base64,...").
+	 * @param preserveOpenTabs When true, skips the new-tab editor cleanup (revert + close-all), preserving open tabs and dirty/unsaved editors.
 	 * @returns The ID of the new task.
 	 */
 	startNewTask({
 		configuration,
 		text,
 		images,
 		newTab,
+		preserveOpenTabs,
 	}: {
 		configuration?: RooCodeSettings
 		text?: string
 		images?: string[]
 		newTab?: boolean
+		preserveOpenTabs?: boolean
 	}): Promise<string>
 	/**
 	 * Resumes a task with the given ID.
@@ -109,6 +112,15 @@ export interface RooCodeAPI extends EventEmitter<RooCodeAPIEvents> {
 	 * confirming a completion result. No-ops if no task is active.
 	 */
 	approveCurrentAsk(): Promise<void>
+	/**
+	 * Programmatically approves the pending ask for a task by ID. Intended for use in tests only.
+	 */
+	approveTaskAsk(taskId: string): Promise<boolean>
+	/**
+	 * Simulates selecting a follow-up suggestion for a task by ID, including its optional mode switch.
+	 * Intended for use in tests only.
+	 */
+	selectTaskFollowupSuggestion(options: { taskId: string; answer: string; mode?: string }): Promise<boolean>
 	/**
 	 * Returns true if the API is ready to use.
 	 */
@@ -119,10 +131,16 @@ export interface RooCodeAPI extends EventEmitter<RooCodeAPIEvents> {
 	 */
 	getConfiguration(): RooCodeSettings
 	/**
-	 * Sets the configuration for the current task.
+	 * Sets the configuration for the extension. Writes target the extension-host (sidebar) view:
+	 * view-local values are pinned to the sidebar's per-view state, while global values are
+	 * written to the shared ContextProxy.
 	 * @param values An object containing key-value pairs to set.
 	 */
 	setConfiguration(values: RooCodeSettings): Promise<void>
+	/**
+	 * Returns a value from VS Code globalState. Intended for use in tests only.
+	 */
+	getGlobalState<K extends keyof GlobalState>(key: K): GlobalState[K]
 	/**
 	 * Returns a list of all configured profile names
 	 * @returns Array of profile names

src/extension/__tests__/api-configuration.spec.ts

@@ -1,6 +1,8 @@
 import { describe, expect, it, vi } from "vitest"
 import type * as vscode from "vscode"
 
+import { providerIdentifiers } from "@roo-code/types"
+
 import { API } from "../api"
 import type { ClineProvider } from "../../core/webview/ClineProvider"
 
@@ -17,6 +19,7 @@ describe("API - configuration", () => {
 		const provider = {
 			context: {},
 			on: vi.fn(),
+			setValues,
 			contextProxy: { setValues },
 			providerSettingsManager: { saveConfig, setModeConfig },
 			postStateToWebview,
@@ -50,6 +53,7 @@ describe("API - configuration", () => {
 		const provider = {
 			context: {},
 			on: vi.fn(),
+			setValues,
 			contextProxy: { setValues },
 			providerSettingsManager: { saveConfig, setModeConfig },
 			postStateToWebview,
@@ -62,4 +66,38 @@ describe("API - configuration", () => {
 		expect(setModeConfig).not.toHaveBeenCalled()
 		expect(postStateToWebview).toHaveBeenCalledOnce()
 	})
+
+	it("flattens the nested view-local apiConfiguration and strips its secrets", () => {
+		const getValues = vi.fn().mockReturnValue({
+			mode: "architect",
+			currentApiConfigName: "view-profile",
+			apiConfiguration: {
+				apiProvider: providerIdentifiers.openrouter,
+				openRouterModelId: "openai/gpt-4o",
+				apiKey: "nested-secret-key",
+				openRouterApiKey: "nested-openrouter-secret",
+			},
+		})
+		// Structural double: API.getConfiguration() only reads sidebarProvider.getValues()
+		// from the provider; the double assertion adapts this minimal shape to the
+		// constructor's ClineProvider parameter (same pattern as the tests above).
+		const provider = {
+			context: {},
+			on: vi.fn(),
+			getValues,
+		} as unknown as ClineProvider
+		const outputChannel = { appendLine: vi.fn() } as unknown as vscode.OutputChannel
+		const api = new API(outputChannel, provider)
+
+		const configuration = api.getConfiguration()
+
+		expect(getValues).toHaveBeenCalledOnce()
+		expect(configuration.mode).toBe("architect")
+		expect(configuration.currentApiConfigName).toBe("view-profile")
+		expect(configuration.apiProvider).toBe(providerIdentifiers.openrouter)
+		expect(configuration.openRouterModelId).toBe("openai/gpt-4o")
+		expect(configuration).not.toHaveProperty("apiConfiguration")
+		expect(configuration).not.toHaveProperty("apiKey")
+		expect(configuration).not.toHaveProperty("openRouterApiKey")
+	})
 })

src/extension/__tests__/api-set-configuration.spec.ts

@@ -0,0 +1,55 @@
+import { describe, expect, it, vi } from "vitest"
+
+import { providerIdentifiers } from "@roo-code/types"
+
+import { API } from "../api"
+import type { ClineProvider } from "../../core/webview/ClineProvider"
+import type { OutputChannel } from "vscode"
+
+vi.mock("@roo-code/ipc", () => ({
+	IpcServer: class {},
+}))
+
+vi.mock("../../integrations/terminal/Terminal", () => ({
+	Terminal: {
+		getTerminalProfile: vi.fn(),
+		setTerminalProfile: vi.fn(),
+	},
+}))
+
+vi.mock("../../integrations/terminal/TerminalRegistry", () => ({
+	TerminalRegistry: {
+		closeIdleTerminals: vi.fn(),
+	},
+}))
+
+describe("API.setConfiguration", () => {
+	it("routes configuration through ClineProvider.setValues so view-local state stays in sync", async () => {
+		const provider = {
+			context: {},
+			on: vi.fn(),
+			setValues: vi.fn().mockResolvedValue(undefined),
+			contextProxy: {
+				setValues: vi.fn().mockResolvedValue(undefined),
+			},
+			providerSettingsManager: {
+				saveConfig: vi.fn().mockResolvedValue("default-id"),
+			},
+			postStateToWebview: vi.fn().mockResolvedValue(undefined),
+		} as unknown as ClineProvider
+		const api = new API({ appendLine: vi.fn() } as unknown as OutputChannel, provider)
+		const configuration = {
+			apiProvider: providerIdentifiers.bedrock,
+			currentApiConfigName: "default",
+			awsRegion: "us-east-1",
+			apiModelId: "us.anthropic.claude-haiku-4-5-20251001-v1:0",
+		}
+
+		await api.setConfiguration(configuration)
+
+		expect(provider.setValues).toHaveBeenCalledWith(configuration)
+		expect(provider.contextProxy.setValues).not.toHaveBeenCalled()
+		expect(provider.providerSettingsManager.saveConfig).toHaveBeenCalledWith("default", configuration)
+		expect(provider.postStateToWebview).toHaveBeenCalled()
+	})
+})