Add unit test for OtherParamsSelection has more than one bit set.

Signed-off-by: Zhao, Zhiqiang <[email protected]>

Author: Zhiqiang520

unit_test/test_spdm_requester/error_test/negotiate_algorithms_err.c

@@ -123,6 +123,8 @@ static libspdm_return_t libspdm_requester_negotiate_algorithms_test_send_message
         return LIBSPDM_STATUS_SUCCESS;
     case 0x29:
         return LIBSPDM_STATUS_SUCCESS;
+    case 0x2A:
+        return LIBSPDM_STATUS_SUCCESS;
     default:
         return LIBSPDM_STATUS_SEND_FAIL;
     }
@@ -1565,6 +1567,41 @@ static libspdm_return_t libspdm_requester_negotiate_algorithm_test_receive_messa
     }
         return LIBSPDM_STATUS_SUCCESS;
 
+    case 0x2A: {
+        spdm_algorithms_response_t *spdm_response;
+        size_t spdm_response_size;
+        size_t transport_header_size;
+
+        spdm_response_size = sizeof(spdm_algorithms_response_t);
+        transport_header_size = libspdm_transport_test_get_header_size(spdm_context);
+        spdm_response = (void *)((uint8_t *)*response + transport_header_size);
+
+        libspdm_zero_mem(spdm_response, spdm_response_size);
+        spdm_response->header.spdm_version = SPDM_MESSAGE_VERSION_12;
+        spdm_response->header.request_response_code = SPDM_ALGORITHMS;
+        spdm_response->header.param1 = 0;
+        spdm_response->header.param2 = 0;
+        spdm_response->length = sizeof(spdm_algorithms_response_t);
+        spdm_response->measurement_specification_sel =
+            SPDM_MEASUREMENT_BLOCK_HEADER_SPECIFICATION_DMTF;
+        /* Two bits set when only one should be set. */
+        spdm_response->other_params_support =
+            SPDM_ALGORITHMS_OPAQUE_DATA_FORMAT_0 |
+            SPDM_ALGORITHMS_OPAQUE_DATA_FORMAT_1;
+        spdm_response->measurement_hash_algo =
+            m_libspdm_use_measurement_hash_algo;
+        spdm_response->base_asym_sel = m_libspdm_use_asym_algo;
+        spdm_response->base_hash_sel = m_libspdm_use_hash_algo;
+        spdm_response->ext_asym_sel_count = 0;
+        spdm_response->ext_hash_sel_count = 0;
+
+        libspdm_transport_test_encode_message(spdm_context, NULL, false,
+                                              false, spdm_response_size,
+                                              spdm_response,
+                                              response_size, response);
+    }
+        return LIBSPDM_STATUS_SUCCESS;
+
     default:
         return LIBSPDM_STATUS_RECEIVE_FAIL;
     }
@@ -2653,7 +2690,7 @@ static void libspdm_test_requester_negotiate_algorithms_error_case35(void **stat
 }
 
 /**
- * Test 35: MeasurementSpecificationSel has more than one bit set.
+ * Test 36: MeasurementSpecificationSel has more than one bit set.
  * Expected behavior: returns with status LIBSPDM_STATUS_INVALID_MSG_FIELD.
  **/
 static void libspdm_test_requester_negotiate_algorithms_error_case36(void **state)
@@ -2854,6 +2891,33 @@ static void libspdm_test_requester_negotiate_algorithms_error_case40(void** stat
     assert_int_equal(status, LIBSPDM_STATUS_INVALID_MSG_FIELD);
 }
 
+/**
+ * Test 41: OtherParamsSelection is added in SPDM 1.2.
+ * OtherParamsSelection has more than one bit set.
+ * Expected behavior: returns with status LIBSPDM_STATUS_INVALID_MSG_FIELD.
+ **/
+static void libspdm_test_requester_negotiate_algorithms_error_case41(void **state)
+{
+    libspdm_return_t status;
+    libspdm_test_context_t *spdm_test_context;
+    libspdm_context_t *spdm_context;
+
+    spdm_test_context = *state;
+    spdm_context = spdm_test_context->spdm_context;
+    spdm_test_context->case_id = 0x2A;
+    spdm_context->connection_info.version = SPDM_MESSAGE_VERSION_12 <<
+                                            SPDM_VERSION_NUMBER_SHIFT_BIT;
+    spdm_context->connection_info.connection_state = LIBSPDM_CONNECTION_STATE_AFTER_CAPABILITIES;
+    spdm_context->local_context.algorithm.measurement_hash_algo =
+        m_libspdm_use_measurement_hash_algo;
+    spdm_context->local_context.algorithm.base_asym_algo = m_libspdm_use_asym_algo;
+    spdm_context->local_context.algorithm.base_hash_algo = m_libspdm_use_hash_algo;
+    libspdm_reset_message_a(spdm_context);
+
+    status = libspdm_negotiate_algorithms(spdm_context);
+    assert_int_equal(status, LIBSPDM_STATUS_NEGOTIATION_FAIL);
+}
+
 libspdm_test_context_t m_libspdm_requester_negotiate_algorithms_test_context = {
     LIBSPDM_TEST_CONTEXT_VERSION,
     true,
@@ -2907,6 +2971,7 @@ int libspdm_requester_negotiate_algorithms_error_test_main(void)
         cmocka_unit_test(libspdm_test_requester_negotiate_algorithms_error_case38),
         cmocka_unit_test(libspdm_test_requester_negotiate_algorithms_error_case39),
         cmocka_unit_test(libspdm_test_requester_negotiate_algorithms_error_case40),
+        cmocka_unit_test(libspdm_test_requester_negotiate_algorithms_error_case41),
     };
 
     libspdm_setup_test_context(&m_libspdm_requester_negotiate_algorithms_test_context);