`configToVideoStream ` can create streams whose timebase are above INT32_MAX

[nicole-branagan]

If this occurs, then attempts to use av_packet_rescale_ts_js will fail, because the arguments to that function must be an integer.

[Yahweasel]

I'm a bit confused. videoStreamToConfig just reads in a stream. Do you mean configToVideoStream?

If so... yeah, you're absolutely right. Damn, I didn't think about that. Just because a number is a 64-bit float doesn't mean we can destructure it to a ratio of two 32-bit ints 🤪

Do you have an example configuration with a framerate that causes this issue? Perhaps I should just stick to microseconds if the framerate isn't obvious, instead of trying to be a math hero.

[nicole-branagan]

Yep sorry I mistyped, this is about configToVideoStream. One example file that had the issue had a framerate of 268435456, 6442450947.

[Yahweasel]

You mean it divined a timebase of 268435456, 6442450947 from the framerate, yes? I don't suppose you know the original, floating-point framerate?

(I tried to specifically handle the NTSC 1001 cases, but I did it rather brutally, so I'm curious where this framerate number came from. This looks like the real framerate is 24FPS, but it must have inferred a slightly higher framerate somewhere.)