Skip to content

Commit e4ea26f

Browse files
committed
Added detailed explanation for the opn2_setScaleModulators() function
#125 stuerp/foo_midi#108
1 parent da1ec35 commit e4ea26f

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

include/opnmidi.h

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,20 @@ extern OPNMIDI_DECLSPEC void opn2_setChipType(struct OPN2_MIDIPlayer *device, in
418418
extern OPNMIDI_DECLSPEC int opn2_getChipType(struct OPN2_MIDIPlayer *device);
419419

420420
/**
421-
* @brief Override Enable(1) or Disable(0) scaling of modulator volumes. -1 - use bank default scaling of modulator volumes
421+
* @brief Override Enable(1) or Disable(0) scaling of modulators by volumes. -1 - use bank default scaling of modulator volumes
422422
* @param device Instance of the library
423423
* @param smod 0 - disabled, 1 - enabled
424+
*
425+
* When this feature is enabled, all the modulators will scale together with the volume
426+
* that will cuase an effect of sound smoothing. However, it's better to use the CC74
427+
* to explicitly control the volume of modulators when it's needed, otherwise using
428+
* of this feature causes a lot of problems. It's possible that this feature will be
429+
* removed eventually and this function will become useless.
430+
*
431+
* IMPORTANT: If you develop music player or plugin, or integrate this to somewhere,
432+
* suggested to don't add binding to this feature and keep it always disabled.
433+
*
434+
* Details: https://github.com/Wohlstand/libOPNMIDI/issues/125
424435
*/
425436
extern OPNMIDI_DECLSPEC void opn2_setScaleModulators(struct OPN2_MIDIPlayer *device, int smod);
426437

0 commit comments

Comments
 (0)