Skip to content

Commit 2d544bd

Browse files
committed
Remove string-based ExecuteAsync methods from GraphQLClient and update GraphQLRequest for implicit conversion from string
1 parent 8d1237c commit 2d544bd

File tree

2 files changed

+5
-20
lines changed

2 files changed

+5
-20
lines changed

GraphQLSharp/Client/GraphQLClient.cs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ public GraphQLClient(TClientOptions defaultOptions = null) : base(defaultOptions
1515
{
1616
}
1717

18-
public Task<GraphQLResponse<TMutationRoot>> ExecuteMutationAsync([StringSyntax("GraphQL")] string query, TClientOptions options = null, CancellationToken cancellationToken = default)
19-
{
20-
return ExecuteAsync<TMutationRoot>(query, options, cancellationToken);
21-
}
22-
2318
public Task<GraphQLResponse<TMutationRoot>> ExecuteMutationAsync(TGraphQLRequest request, TClientOptions options = null, CancellationToken cancellationToken = default)
2419
{
2520
return ExecuteAsync<TMutationRoot>(request, options, cancellationToken);
@@ -35,11 +30,6 @@ public GraphQLClient(TClientOptions defaultOptions = null) : base(defaultOptions
3530
{
3631
}
3732

38-
public Task<GraphQLResponse<TQueryRoot>> ExecuteQueryAsync([StringSyntax("GraphQL")] string query, TClientOptions options = null, CancellationToken cancellationToken = default)
39-
{
40-
return ExecuteAsync<TQueryRoot>(query, options, cancellationToken);
41-
}
42-
4333
public Task<GraphQLResponse<TQueryRoot>> ExecuteQueryAsync(TGraphQLRequest request, TClientOptions options = null, CancellationToken cancellationToken = default)
4434
{
4535
return ExecuteAsync<TQueryRoot>(request, options, cancellationToken);
@@ -71,16 +61,6 @@ public GraphQLClient(TClientOptions defaultOptions = null)
7161
_defaultOptions = defaultOptions;
7262
}
7363

74-
public Task<GraphQLResponse<JsonElement>> ExecuteAsync([StringSyntax("GraphQL")] string query, TClientOptions options = null, CancellationToken cancellationToken = default)
75-
{
76-
return ExecuteAsync<JsonElement>(query, options, cancellationToken);
77-
}
78-
79-
public Task<GraphQLResponse<T>> ExecuteAsync<T>([StringSyntax("GraphQL")] string query, TClientOptions options = null, CancellationToken cancellationToken = default)
80-
{
81-
return ExecuteAsync<T>(new TGraphQLRequest { query = query }, options, cancellationToken);
82-
}
83-
8464
public Task<GraphQLResponse<JsonElement>> ExecuteAsync(TGraphQLRequest request, TClientOptions options = null, CancellationToken cancellationToken = default)
8565
{
8666
//returing JsonElement and not JsonDocument because JsonDocument is disposable and we don't want to force the user to dispose it

GraphQLSharp/Client/GraphQLRequest.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,9 @@ public override string ToString()
2020
variables: {JsonSerializer.Serialize(variables, new JsonSerializerOptions { WriteIndented = true })},
2121
""";
2222
}
23+
24+
public static implicit operator GraphQLRequest(string query)
25+
{
26+
return new GraphQLRequest { query = query };
27+
}
2328
}

0 commit comments

Comments
 (0)