Rename APP to RAFT_APPLICATION

Summary:
Change the name of the macro used for the RAFT application name from `APP` to `RAFT_APPLICATION`
as `APP` is a bit too short of a name to be using in a general header.

Reviewed By: jaher

Differential Revision: D78371737

fbshipit-source-id: 46732460eb1b6448fdbb00ce3243e45d16674cad

Author: hsun324

include/wa_raft.hrl

@@ -5,7 +5,8 @@
 %%%
 %%% This file defines general macros and data structures shared across modules.
 
--define(APP, wa_raft).
+%% The name of the RAFT application.
+-define(RAFT_APPLICATION, wa_raft).
 
 %%-------------------------------------------------------------------
 %% Registered information about applications and partitions
@@ -78,7 +79,7 @@
 %% Metrics
 %%-------------------------------------------------------------------
 
--define(RAFT_METRICS_MODULE_KEY, {?APP, raft_metrics_module}).
+-define(RAFT_METRICS_MODULE_KEY, {?RAFT_APPLICATION, raft_metrics_module}).
 -define(RAFT_METRICS_MODULE, (persistent_term:get(?RAFT_METRICS_MODULE_KEY, wa_raft_metrics))).
 -define(RAFT_COUNT(Metric), ?RAFT_METRICS_MODULE:count(Metric)).
 -define(RAFT_COUNTV(Metric, Value), ?RAFT_METRICS_MODULE:countv(Metric, Value)).
@@ -90,8 +91,8 @@
 %%-------------------------------------------------------------------
 
 %% Get global config
--define(RAFT_CONFIG(Name), (application:get_env(?APP, Name))).
--define(RAFT_CONFIG(Name, Default), (application:get_env(?APP, Name, Default))).
+-define(RAFT_CONFIG(Name), (application:get_env(?RAFT_APPLICATION, Name))).
+-define(RAFT_CONFIG(Name, Default), (application:get_env(?RAFT_APPLICATION, Name, Default))).
 
 %% Default metrics module
 -define(RAFT_METRICS_MODULE(), ?RAFT_CONFIG(raft_metrics_module)).

src/wa_raft_env.erl

@@ -54,7 +54,7 @@ get_env(Scope, Key, Default) ->
 
 -spec get_env_impl(SearchApps :: [atom()], Key :: atom(), FallbackKey :: atom()) -> {ok, Value :: dynamic()} | undefined.
 get_env_impl([], _Key, FallbackKey) ->
-    application:get_env(?APP, FallbackKey);
+    ?RAFT_CONFIG(FallbackKey);
 get_env_impl([App | SearchApps], Key, FallbackKey) ->
     case application:get_env(App, Key) of
         {ok, Value} -> {ok, Value};

src/wa_raft_sup.erl

@@ -149,7 +149,7 @@ default_name(Application) ->
 
 -spec default_config_apps(Application :: atom()) -> [atom()].
 default_config_apps(Application) ->
-    [Application, ?APP].
+    [Application, ?RAFT_APPLICATION].
 
 -spec registered_config_apps(Application :: atom()) -> [atom()].
 registered_config_apps(Application) ->