elp ssr: set info priority when --dump-config is set

Summary:
As title.

It does not make sense to have at least info severity in the IDE, otherwise the squiggles do not show up.

Reviewed By: jcpetruzza

Differential Revision: D86774246

fbshipit-source-id: 0db22ecf1b90c7e7a2d2037c0c45cc8619928c44

Author: alanz

crates/elp/src/bin/args.rs

@@ -372,10 +372,6 @@ pub struct Ssr {
     )]
     pub format: Option<String>,
 
-    /// Report severity as Info instead of WeakWarning
-    #[bpaf(long("info"))]
-    pub info_severity: bool,
-
     /// Macro expansion strategy: expand | no-expand | visible-expand (default expand)
     #[bpaf(
         long("macros"),

crates/elp/src/bin/main.rs

@@ -2117,7 +2117,18 @@ mod tests {
     #[test]
     fn lint_ssr_as_cli_dump_config() {
         simple_snapshot(
-            args_vec!["ssr", "--dump-config", "--info", "?BAR(_@AA)", "{4}"],
+            args_vec!["ssr", "--dump-config", "?BAR(_@AA)", "{4}"],
+            "linter",
+            expect_file!("../resources/test/linter/ssr_ad_hoc_cli_dump_config.stdout"),
+            true,
+            None,
+        )
+    }
+
+    #[test]
+    fn lint_ssr_as_cli_dump_config_without_info() {
+        simple_snapshot(
+            args_vec!["ssr", "--dump-config", "?BAR(_@AA)", "{4}"],
             "linter",
             expect_file!("../resources/test/linter/ssr_ad_hoc_cli_dump_config.stdout"),
             true,

crates/elp/src/bin/ssr_cli.rs

@@ -86,7 +86,8 @@ pub fn run_ssr_command(
     let mut lint_config = LintConfig::default();
     for pattern in &args.ssr_specs {
         let normalized_pattern = normalize_ssr_pattern(pattern);
-        let severity = if args.info_severity {
+        let severity = if args.dump_config {
+            // Set the severity so that squiggles are shown in the VS Code UI
             Some(diagnostics::Severity::Information)
         } else {
             None

crates/elp/src/resources/test/ssr_help.stdout

@@ -1,4 +1,4 @@
-Usage: [--project PROJECT] [--module MODULE] [--app APP] [--file FILE] [--rebar] [--as PROFILE] [--include-generated] [--include-tests] [[--format FORMAT]] [--info] [[--macros STRATEGY]] [--parens] [--dump-config] [--report-system-stats] <SSR_SPECS>...
+Usage: [--project PROJECT] [--module MODULE] [--app APP] [--file FILE] [--rebar] [--as PROFILE] [--include-generated] [--include-tests] [[--format FORMAT]] [[--macros STRATEGY]] [--parens] [--dump-config] [--report-system-stats] <SSR_SPECS>...
 
 Available positional items:
     <SSR_SPECS>  SSR specs to use
@@ -13,7 +13,6 @@ Available options:
         --include-generated    Also generate diagnostics for generated files
         --include-tests        Also generate diagnostics for test files
         --format <FORMAT>      Show diagnostics in JSON format
-        --info                 Report severity as Info instead of WeakWarning
         --macros <STRATEGY>    Macro expansion strategy: expand | no-expand | visible-expand (default expand)
         --parens               Explicitly match parentheses. If omitted, they are ignored.
         --dump-config          Dump a configuration snippet that can be put in .elp_lint.toml to match the given SSR patterns