CLI ssr: Add --dump-config for .elp_lint.toml config snippet

Summary:
We can use the command line `elp ssr` command to search through files in a project for matches, but it is also convenient to be able to examine them in an IDE context.

This diff adds this capability, with two new command line options
- `--info` upgrades the reported diagnostic from weak warning to info
- `--dump-config` emits a toml snippet suitable for placement at the end of an `.elp_lint.toml` file.

```bash
elp ssr --parens --dump-config --info "(3)" "{_A}"

# Add this to your .elp_lint.toml
[[ad_hoc_lints.lints]]
type = "LintMatchSsr"
ssr_pattern = "ssr: (3)."
severity = "info"
macro_strategy = "expand"
paren_strategy = "visible"

[[ad_hoc_lints.lints]]
type = "LintMatchSsr"
ssr_pattern = "ssr: {_A}."
severity = "info"
macro_strategy = "expand"
paren_strategy = "visible"
```

The edit to `.elp_lint.toml` will be immediately picked up, and you will see the matches as normal diagnostics with a blue squiggle for info.

Reviewed By: TD5

Differential Revision: D85960380

fbshipit-source-id: 803c19f1917d939d13e6406e440057632b489ea6

Author: alanz

crates/elp/src/bin/args.rs

@@ -372,6 +372,10 @@ pub struct Ssr {
     )]
     pub format: Option<String>,
 
+    /// Report severity as Info instead of WeakWarning
+    #[bpaf(long("info"))]
+    pub info_severity: bool,
+
     /// Macro expansion strategy: expand | no-expand | visible-expand (default expand)
     #[bpaf(
         long("macros"),
@@ -386,6 +390,9 @@ pub struct Ssr {
     #[bpaf(long("parens"))]
     pub paren_strategy: bool,
 
+    /// Dump a configuration snippet that can be put in .elp_lint.toml to match the given SSR patterns
+    pub dump_config: bool,
+
     /// Report system memory usage and other statistics
     #[bpaf(long("report-system-stats"))]
     pub report_system_stats: bool,

crates/elp/src/bin/main.rs

@@ -2114,6 +2114,17 @@ mod tests {
         )
     }
 
+    #[test]
+    fn lint_ssr_as_cli_dump_config() {
+        simple_snapshot(
+            args_vec!["ssr", "--dump-config", "--info", "?BAR(_@AA)", "{4}"],
+            "linter",
+            expect_file!("../resources/test/linter/ssr_ad_hoc_cli_dump_config.stdout"),
+            true,
+            None,
+        )
+    }
+
     #[test_case(false ; "rebar")]
     #[test_case(true  ; "buck")]
     fn eqwalizer_tests_check(buck: bool) {

crates/elp/src/bin/ssr_cli.rs

@@ -28,6 +28,7 @@ use elp_ide::diagnostics;
 use elp_ide::diagnostics::DiagnosticsConfig;
 use elp_ide::diagnostics::FallBackToAll;
 use elp_ide::diagnostics::LintConfig;
+use elp_ide::diagnostics::LintsFromConfig;
 use elp_ide::diagnostics::MatchSsr;
 use elp_ide::elp_ide_db::elp_base_db::AbsPath;
 use elp_ide::elp_ide_db::elp_base_db::FileId;
@@ -85,10 +86,16 @@ pub fn run_ssr_command(
     let mut lint_config = LintConfig::default();
     for pattern in &args.ssr_specs {
         let normalized_pattern = normalize_ssr_pattern(pattern);
+        let severity = if args.info_severity {
+            Some(diagnostics::Severity::Information)
+        } else {
+            None
+        };
         let ssr_lint = diagnostics::Lint::LintMatchSsr(MatchSsr {
             ssr_pattern: normalized_pattern,
             message: None,
             strategy: Some(strategy),
+            severity,
         });
         lint_config.ad_hoc_lints.lints.push(ssr_lint);
     }
@@ -105,8 +112,13 @@ pub fn run_ssr_command(
         .set_experimental(false)
         .set_use_cli_severity(false);
 
-    if diagnostics_config.enabled.all_enabled() && args.is_format_normal() {
-        writeln!(cli, "Reporting all diagnostics codes")?;
+    if args.dump_config {
+        let result = toml::to_string::<LintsFromConfig>(&diagnostics_config.lints_from_config)?;
+        // This is a subsection of .elp_lint.toml, add subsection prefix
+        let result = result.replace("[[lints]]", "[[ad_hoc_lints.lints]]");
+        writeln!(cli, "\n# Add this to your .elp_lint.toml")?;
+        writeln!(cli, "{}", result)?;
+        return Ok(());
     }
 
     // Load the project

crates/elp/src/lib.rs

@@ -193,6 +193,7 @@ mod tests {
                         ssr_pattern: "ssr: _@A = 10.".to_string(),
                         message: None,
                         strategy: None,
+                        severity: None,
                     }),
                 ],
             },

crates/elp/src/resources/test/linter/ssr_ad_hoc_cli_dump_config.stdout

@@ -0,0 +1,12 @@
+
+# Add this to your .elp_lint.toml
+[[ad_hoc_lints.lints]]
+type = "LintMatchSsr"
+ssr_pattern = "ssr: ?BAR(_@AA)."
+severity = "info"
+
+[[ad_hoc_lints.lints]]
+type = "LintMatchSsr"
+ssr_pattern = "ssr: {4}."
+severity = "info"
+

crates/elp/src/resources/test/ssr_help.stdout

@@ -1,4 +1,4 @@
-Usage: [--project PROJECT] [--module MODULE] [--app APP] [--file FILE] [--rebar] [--as PROFILE] [--include-generated] [--include-tests] [[--format FORMAT]] [[--macros STRATEGY]] [--parens] [--report-system-stats] <SSR_SPECS>...
+Usage: [--project PROJECT] [--module MODULE] [--app APP] [--file FILE] [--rebar] [--as PROFILE] [--include-generated] [--include-tests] [[--format FORMAT]] [--info] [[--macros STRATEGY]] [--parens] [--dump-config] [--report-system-stats] <SSR_SPECS>...
 
 Available positional items:
     <SSR_SPECS>  SSR specs to use
@@ -13,7 +13,9 @@ Available options:
         --include-generated    Also generate diagnostics for generated files
         --include-tests        Also generate diagnostics for test files
         --format <FORMAT>      Show diagnostics in JSON format
+        --info                 Report severity as Info instead of WeakWarning
         --macros <STRATEGY>    Macro expansion strategy: expand | no-expand | visible-expand (default expand)
         --parens               Explicitly match parentheses. If omitted, they are ignored.
+        --dump-config          Dump a configuration snippet that can be put in .elp_lint.toml to match the given SSR patterns
         --report-system-stats  Report system memory usage and other statistics
     -h, --help                 Prints help information