Define is_in_otp as a File method

Summary:
Small follow-up from D44162698.

Define the `is_in_otp` helper as part of `File`, to make it more discoverable.

Reviewed By: jcpetruzza

Differential Revision: D84890853

fbshipit-source-id: 7e57f58c75a6db506196318f9e93afdefc03fd1d

Author: robertoaloi

crates/hir/src/module_data.rs

@@ -91,6 +91,19 @@ impl File {
     pub fn def_map(&self, db: &dyn DefDatabase) -> Arc<DefMap> {
         db.def_map(self.file_id)
     }
+
+    pub fn is_in_otp(&self, db: &dyn DefDatabase) -> bool {
+        let file_id = self.file_id;
+        // Context for T171541590
+        let _ = stdx::panic_context::enter(format!("\nis_in_otp:2: {file_id:?}"));
+        match db.file_app_data(file_id) {
+            Some(app_data) => {
+                let project_id = app_data.project_id;
+                db.project_data(project_id).otp_project_id == Some(project_id)
+            }
+            None => false,
+        }
+    }
 }
 
 /// Represents a module definition
@@ -111,7 +124,7 @@ impl Module {
     }
 
     pub fn is_in_otp(&self, db: &dyn DefDatabase) -> bool {
-        is_in_otp(self.file.file_id, db)
+        self.file.is_in_otp(db)
     }
 
     pub fn has_moduledoc(&self, db: &dyn DefDatabase) -> bool {
@@ -270,7 +283,7 @@ impl FunctionDef {
     }
 
     pub fn is_in_otp(&self, db: &dyn DefDatabase) -> bool {
-        is_in_otp(self.file.file_id, db)
+        self.file.is_in_otp(db)
     }
 
     pub fn edoc_comments(&self, db: &dyn DefDatabase) -> Option<EdocHeader> {
@@ -697,15 +710,3 @@ impl VarDef {
         db.lookup_var(self.hir_var).clone()
     }
 }
-
-fn is_in_otp(file_id: FileId, db: &dyn DefDatabase) -> bool {
-    // Context for T171541590
-    let _ = stdx::panic_context::enter(format!("\nis_in_otp:2: {file_id:?}"));
-    match db.file_app_data(file_id) {
-        Some(app_data) => {
-            let project_id = app_data.project_id;
-            db.project_data(project_id).otp_project_id == Some(project_id)
-        }
-        None => false,
-    }
-}