fix(): Check exit code for installs (#31)

Modify `Start-Process` code to check for a successful exit code. If the code is non-zero the installation fails.

Fixes an issue where xampp installs were silently failing because there's no executable to verify.

Author: donny-dont

WebKitDev/Functions/Install-FromExe.ps1

@@ -46,7 +46,15 @@ function Install-FromExe {
     Write-Information -MessageData ('Installing {0} ...' -f $name) -InformationAction Continue;
     Write-Information -MessageData ('{0} {1}' -f $installerPath,($options -join ' ')) -InformationAction Continue;
 
-    Start-Process $installerPath -Wait -ArgumentList $options;
+    # According to https://stackoverflow.com/a/23797762 caching the handle is required to get ExitCode
+    $process = Start-Process $installerPath -PassThru -ArgumentList $options;
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUserDeclaredVarsMoreThanAssignments', '', Scope='Function')]
+    $handle = $process.Handle;
+    $process.WaitForExit();
+
+    if ($process.ExitCode -ne 0) {
+        Write-Error ('{0} installer failed with exit code {1}' -f $name, $process.ExitCode) -ErrorAction Stop;
+    }
 
     # Update path
     Update-ScriptPath;

WebKitDev/Functions/Install-FromMsi.ps1

@@ -49,7 +49,15 @@ function Install-FromMsi {
     Write-Information -MessageData ('Installing {0} ...' -f $name) -InformationAction Continue;
     Write-Information -MessageData ('msiexec {0}' -f ($msiArgs -join ' ')) -InformationAction Continue;
 
-    Start-Process msiexec -Wait -ArgumentList $msiArgs;
+    # According to https://stackoverflow.com/a/23797762 caching the handle is required to get ExitCode
+    $process = Start-Process msiexec -PassThru -ArgumentList $msiArgs;
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUserDeclaredVarsMoreThanAssignments', '', Scope='Function')]
+    $handle = $process.Handle;
+    $process.WaitForExit();
+
+    if ($process.ExitCode -ne 0) {
+        Write-Error ('{0} installer failed with exit code {1}' -f $name, $process.ExitCode) -ErrorAction Stop;
+    }
 
     # Update path
     Update-ScriptPath;