Skip to content

Commit 7aa297f

Browse files
authored
Add ability to change keepalive value (#338)
Use an environment variable, `BUILD_WORKER_KEEPALIVE`, to control the keepalive value set in the `buildbot.tac` file. Defaults to `240` which seemed to prevent disconnects of the worker in webkit infrastructure.
1 parent b643bf2 commit 7aa297f

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

buildbot-worker/BuildbotWorker/Run-BuildbotWorker.ps1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ Write-Host 'Buildbot information';
3434
Write-Host ('Name: {0}' -f $env:BUILD_WORKER_NAME);
3535
Write-Host ('Admin: {0} <{1}>' -f $env:ADMIN_NAME,$env:ADMIN_EMAIL);
3636
Write-Host ('Description: {0}' -f $env:HOST_DESCRIPTION);
37+
Write-Host ('Keep-alive: {0}' -f $env:BUILD_WORKER_KEEPALIVE);
3738

3839
# Print the host information
3940
$cs = Get-WmiObject -Class Win32_ComputerSystem;

buildbot-worker/BuildbotWorker/buildbot.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def _get_options():
1212
'port': os.environ.get('BUILD_HOST_PORT', '17000'),
1313
'worker': os.environ.get('BUILD_WORKER_NAME'),
1414
'password': os.environ.get('BUILD_WORKER_PASSWORD'),
15+
'keepalive': os.environ.get('BUILD_WORKER_KEEPALIVE', '240'),
1516
# info/admin
1617
'name': os.environ.get('ADMIN_NAME'),
1718
'email': os.environ.get('ADMIN_EMAIL'),

buildbot-worker/BuildbotWorker/buildbot.tac.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ buildmaster_host = '$host'
2626
port = $port
2727
workername = '$worker'
2828
passwd = '$password'
29-
keepalive = 600
29+
keepalive = $keepalive
3030
umask = 0o022
3131
maxdelay = 300
3232
numcpus = None

0 commit comments

Comments
 (0)