Skip to content

Conversation

@lionellbriones
Copy link

@lionellbriones lionellbriones commented May 13, 2025

Description

Added protection against Brute-force in Onboarding-Unlock page.
To prevent brute forcability, we are staggering password failures

  • 1st - 3rd failure: No delay
  • 4th failure: 30-second delay
  • 5th failure: 1-minute delay
  • 6th failure: 5-minute delay
  • 7th failure: 15-minute delay
  • 8th failure: 30-minute delay
  • 9th failure: 45-minute delay
  • 10th failure: 1-hour lockout
  • more than 10th failure: Incremental lockout (up to 1 day)
  • After 1 day(24 hr), its 24hr lockout on every attempt*

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Log into existing wallet with the Social Login
  2. Enter incorrect passwords for multiple times

Screenshots/Recordings

Before

After

rate-limit.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link

github-actions bot commented May 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@lwin-kyaw lwin-kyaw changed the title feat: add rate limit error and hint on unlock page feat: add rate limit error on unlock page May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants