feat: CRMMON-8029 focus on button #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mt-anna
reviewed
Oct 4, 2024
louisua
force-pushed
the
feature/CRMMON-8029
branch
2 times, most recently
from
55e1ea4 to
3938558
Compare
Contributor
|
video please |
Author
|
|
Author
|
@gregpetit voici les changements que j'ai fait |
mt-anna
approved these changes
Oct 8, 2024
Contributor
|
'dropzoneElement' is declared but its value is never read.ts(6133) |
louisua
force-pushed
the
feature/CRMMON-8029
branch
from
3938558 to
bea170e
Compare
Signed-off-by: louisua <[email protected]>
louisua
force-pushed
the
feature/CRMMON-8029
branch
from
bea170e to
6ea4530
Compare
Author
video_louisua.webm |
Member
|
@MaudeLaflamme can you make a quick check, since I know you use it so perhaps you could have a feedback on it 👀 |
Member
|
also build failed, it seems to be a linting issue, can you fix it @louisua ? |
Collaborator
|
@louisua Salut, pourrais-tu pousser un build sur Chromatic afin qu'on puisse tester tes changements ? |
Contributor
|
@louisua As-tu finalement réussit à builder dans Chromatic? |
MaudeLaflamme
force-pushed
the
master-16
branch
2 times, most recently
from
ab0434b to
9e5d8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File input component accessibility
Instead of focus on input when navigating by tab, focus on button so it can upload the file automatically