Skip to content

Commit f00e9a7

Browse files
authored
Spelling and Markdown (#82)
1 parent b1cff09 commit f00e9a7

File tree

10 files changed

+40
-25
lines changed

10 files changed

+40
-25
lines changed

app/victoria-traces/servicegraph/servicegraph.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ func GenerateServiceGraphTimeRange(ctx context.Context) {
9595
// persist service graph relations
9696
err = vtinsert.PersistServiceGraph(ctx, tenantID, rows, endTime)
9797
if err != nil {
98-
logger.Errorf("cannot presist service graph for time range [%d, %d]: %s", startTime.Unix(), endTime.Unix(), err)
98+
logger.Errorf("cannot persist service graph for time range [%d, %d]: %s", startTime.Unix(), endTime.Unix(), err)
9999
}
100100
}
101101
}

app/vmui/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,31 @@ Web UI for VictoriaTraces
1111

1212
Run the following command from the root of VictoriaTraces repository for building `vmui` static contents:
1313

14-
```
14+
```sh
1515
make vmui-build
1616
```
1717

1818
The built static contents is put into `app/vmui/packages/vmui/` directory.
1919

20-
2120
### Updating vmui embedded into VictoriaTraces
2221

2322
Run the following command from the root of VictoriaTraces repository for updating `vmui` embedded into VictoriaTraces:
2423

25-
```
24+
```sh
2625
make vmui-update
2726
```
2827

2928
This command should update `vmui` static files at `app/vtselect/vmui` directory. Commit changes to these files if needed.
3029

3130
Then build VictoriaTraces with the following command:
3231

33-
```
32+
```sh
3433
make victoria-traces
3534
```
3635

3736
Then run the built binary with the following command:
3837

39-
```
38+
```sh
4039
bin/victoria-traces
4140
```
4241

app/vtgen/README.md

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
`vtgen` is a trace data generator. It reads the OTLP request body in `testdata/testdata.bin`, modifies the `trace_id`, `start_time` and `end_time`, and sends them to OTLP trace endpoint (`/v1/traces`).
44

55
### Usage
6+
67
`vtgen` can be used for:
8+
79
1. Generating identical data for different targets, which is useful for query performance benchmarking of different storage backends against the same dataset.
810
2. Generating different data at the same rate (on a best-effort basis) for different targets, which is useful for data ingestion performance benchmarking of different storage backends.
911

1012
You can build `vtgen` via the following commands:
11-
```
13+
14+
```sh
1215
# build via go build
1316
make vtgen
1417
# build via Docker
@@ -20,20 +23,25 @@ These commands will generate `vtgen(-prod)` binary in `bin` folder.
2023
`vtgen` MUST be run from the root path of `VictoriaTraces` repository, to load the test data correctly from `app/vtgen/testdata`.
2124

2225
To send identical data to different targets:
23-
```
26+
27+
```sh
2428
./bin/vtgen -addrs=http://example-url1:port/v1/traces,http://example-url2:port/insert/opentelemetry/v1/traces
2529
```
30+
2631
The performance of different targets will affect each other, as `vtgen` generates data and makes HTTP requests to them one by one.
2732

2833
To send (potentially) different data to different addresses at the same rate, simply run multiple `vtgen` with different HTTP listening port:
29-
```
34+
35+
```sh
3036
./bin/vtgen -addrs=http://example-url1:port/v1/traces -httpListenAddr=0.0.0.0:8080
3137
./bin/vtgen -addrs=http://example-url2:port/insert/opentelemetry/v1/traces -httpListenAddr=0.0.0.0:8081
3238
```
3339

3440
### Metrics
41+
3542
`vtgen` exposes some metrics to help tracking the ingestion performance. Here's the example:
36-
```
43+
44+
```sh
3745
vt_gen_http_request_duration_seconds_bucket{path="http://example-url1:port/v1/traces",vmrange="7.743e-05...8.799e-05"} 8
3846
vt_gen_http_request_duration_seconds_bucket{path="http://example-url1:port/v1/traces",vmrange="3.162e-03...3.594e-03"} 1
3947
vt_gen_http_request_duration_seconds_sum{path="http://example-url1:port/v1/traces"} 0.17367758299999986
@@ -45,6 +53,7 @@ vt_gen_http_request_error_count{path="http://example-url1:port/v1/traces"} 667
4553
- `vt_gen_http_request_error_count` is a `counter` for each address.
4654

4755
### Command-line flags
56+
4857
```
4958
-addrs string
5059
otlp trace export endpoints, split by ",".
@@ -80,4 +89,4 @@ vt_gen_http_request_error_count{path="http://example-url1:port/v1/traces"} 667
8089
Show VictoriaMetrics version
8190
-worker int
8291
number of workers. (default 4)
83-
```
92+
```

app/vtselect/internalselect/internalselect.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,8 @@ func getCommonParams(r *http.Request, expectedProtocolVersion string) (*commonPa
357357
func checkProtocolVersion(r *http.Request, expectedProtocolVersion string) error {
358358
version := r.FormValue("version")
359359
if version != expectedProtocolVersion {
360-
return fmt.Errorf("unexpected protocol version=%q; want %q; the most likely casue of this error is different versions of VictoriaLogs cluster components; "+
361-
"make sure VictoriaLogs compoments have the same release version", version, expectedProtocolVersion)
360+
return fmt.Errorf("unexpected protocol version=%q; want %q; the most likely cause of this error is different versions of VictoriaLogs cluster components; "+
361+
"make sure VictoriaLogs components have the same release version", version, expectedProtocolVersion)
362362
}
363363
return nil
364364
}

app/vtstorage/netselect/netselect.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,8 +495,8 @@ func (s *Storage) DeleteRunTask(ctx context.Context, taskID string, timestamp in
495495
errs := make([]error, len(s.sns))
496496

497497
// Return an error to the caller when at least a single storage node is unavailable.
498-
// This improves awarenes of the caller about unavailable storage nodes.
499-
// If some storage node is unavailable, then the deletetion task
498+
// This improves awareness of the caller about unavailable storage nodes.
499+
// If some storage node is unavailable, then the deletion task
500500
// can start on arbitrary number of the remaining available nodes.
501501
// It is OK to re-run the delete task in this case.
502502
allowPartialResponse := false
@@ -525,7 +525,7 @@ func (s *Storage) DeleteStopTask(ctx context.Context, taskID string) error {
525525
errs := make([]error, len(s.sns))
526526

527527
// Return an error to the caller when at least a single storage node is unavailable.
528-
// This improves awarenes of the caller about unavailable storage nodes.
528+
// This improves awareness of the caller about unavailable storage nodes.
529529
// If some storage node is unavailable, then the deletion task can remain uncanceled on such nodes.
530530
// It is OK to stop the delete task multiple times in this case.
531531
allowPartialResponse := false

codespell/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
# Spell checking
22

3-
This directory contains configuration and instructions for spell checking in
3+
This directory contains configuration and instructions for spell checking in
44
[docs](https://github.com/VictoriaMetrics/VictoriaTraces/tree/master/docs) folder.
55

66
To run execute the following command:
7+
78
```sh
89
make spellcheck
910
```
1011

11-
This command required Docker to build `spellcheck` image and run the spell checks.
12+
This command required Docker to build `spellcheck` image and run the spell checks.

docs/victoriatraces/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ VictoriaTraces provides the following prominent features:
2222
to integrate with [Grafana](https://grafana.com/docs/grafana/latest/datasources/jaeger/) or [Jaeger Frontend](https://www.jaegertracing.io/docs/2.6/frontend-ui/).
2323
- It supports alerting - see [these docs](https://docs.victoriametrics.com/victoriatraces/vmalert/).
2424

25-
If you want to play with the VictoriaTraces demo, simply go to our [Grafana playground](https://play-grafana.victoriametrics.com/explore) to query and visualize the traces,
25+
If you want to play with the VictoriaTraces demo, simply go to our [Grafana playground](https://play-grafana.victoriametrics.com/explore) to query and visualize the traces,
2626
and visit the [VictoriaTraces playground](https://play-vtraces.victoriametrics.com/) to see how trace spans are structured and stored.
2727

2828
## Operation

docs/victoriatraces/changelog/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Released at 2025-11-08
3030

3131
* FEATURE: [Single-node VictoriaTraces](https://docs.victoriametrics.com/victoriatraces/) and [VictoriaTraces cluster](https://docs.victoriametrics.com/victoriatraces/cluster/): support [OTLP/gRPC](https://opentelemetry.io/docs/specs/otlp/#otlpgrpc) data ingestion. It requires `-otlpGRPCListenAddr` flag to be set on Single-node VictoriaTraces or vtinsert. See [this doc](https://docs.victoriametrics.com/victoriatraces/data-ingestion/opentelemetry) for details. Thanks to @JayiceZ for the [pull request](https://github.com/VictoriaMetrics/VictoriaTraces/pull/59).
3232

33-
* BUGFIX: [Single-node VictoriaTraces](https://docs.victoriametrics.com/victoriatraces/) and vtselect in [VictoriaTraces cluster](https://docs.victoriametrics.com/victoriatraces/cluster/): return the correct error message and the total number when searching by trace ID yields no hits in the result. Thank @huan89983 for [the bug report](https://github.com/VictoriaMetrics/VictoriaTraces/issues/77).
33+
* BUGFIX: [Single-node VictoriaTraces](https://docs.victoriametrics.com/victoriatraces/) and vtselect in [VictoriaTraces cluster](https://docs.victoriametrics.com/victoriatraces/cluster/): return the correct error message and the total number when searching by trace ID yields no hits in the result. Thank @huan89983 for [the bug report](https://github.com/VictoriaMetrics/VictoriaTraces/issues/77).
3434

3535
## [v0.4.1](https://github.com/VictoriaMetrics/VictoriaTraces/releases/tag/v0.4.1)
3636

docs/victoriatraces/data-ingestion/opentelemetry.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ The OpenTelemetry provides detailed document and examples for various programmin
3333

3434
You can send data to VictoriaTraces by HTTP or gRPC endpoints.
3535

36-
### HTTP endpoint
36+
### HTTP endpoint
3737

3838
To send data by HTTP endpoint, specify the `EndpointURL` for http-exporter builder to `http://<victoria-traces>:10428/insert/opentelemetry/v1/traces`.
3939

@@ -48,6 +48,7 @@ traceExporter, err := otlptracehttp.New(ctx,
4848
### gRPC endpoint
4949

5050
To send the trace data to VictoriaTraces gRPC trace service, you need to first enable the OTLP gRPC server on VictoriaTraces by:
51+
5152
```shell
5253
./victoria-traces -otlpGRPCListenAddr=:4317 -otlpGRPC.tlsCertFile=<cert_file> -otlpGRPC.tlsKeyFile=<key_file>
5354
```
@@ -57,6 +58,7 @@ To send the trace data to VictoriaTraces gRPC trace service, you need to first e
5758
After that, specify the `Endpoint` for grpc-exporter builder to `<victoria-traces>:4317`.
5859

5960
Consider the following example for Go SDK:
61+
6062
```go
6163
traceExporter, err := otlptracegrpc.New(ctx,
6264
otlptracegrpc.WithEndpoint("<victoria-traces>:4317"),
@@ -100,16 +102,19 @@ exporters:
100102
headers:
101103
VT-Extra-Fields: foo=bar
102104
```
105+
103106
#### gRPC exporter
104107

105108
To send the collected traces to VictoriaTraces gRPC trace service, you need to first enable the OTLP gRPC server on VictoriaTraces by:
109+
106110
```shell
107111
./victoria-traces -otlpGRPCListenAddr=:4317 -otlpGRPC.tlsCertFile=<cert_file> -otlpGRPC.tlsKeyFile=<key_file>
108112
```
109113

110114
> You can also **disable TLS** for incoming gRPC requests by setting `-otlpGRPC.tls=false`. TLS is recommended for production use, and disabling it should only be done when you're testing or aware of the potential risks.
111115

112116
After that, specify endpoint for [OTLP/gRPC exporter](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/otlpexporter/README.md):
117+
113118
```yaml
114119
exporters:
115120
# otlp exporter with TLS
@@ -128,6 +133,7 @@ exporters:
128133
> Optionally, you can specify the `compression` type to one of the following: `gzip` (default), `snappy`, `zstd`, and `none`.
129134

130135
As same as HTTP endpoint, gRPC also support various HTTP headers. For example, the following configs add (or overwrites) `foo: bar` field to each trace span during data ingestion:
136+
131137
```yaml
132138
exporters:
133139
otlp/without-tls:

docs/victoriatraces/quick-start.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,21 +78,21 @@ See how to [write](#write-data) or [read](#read-data) from VictoriaTraces.
7878

7979
### Write data
8080

81-
VictoriaTraces can accept trace spans via [the OpenTelemetry protocol (OTLP)](https://opentelemetry.io/docs/specs/otlp/).
81+
VictoriaTraces can accept trace spans via [the OpenTelemetry protocol (OTLP)](https://opentelemetry.io/docs/specs/otlp/).
8282

8383
It provides the following HTTP API:
8484

8585
- `/insert/opentelemetry/v1/traces`
8686

8787
and the OpenTelemetry Collector gRPC [TraceService](https://github.com/open-telemetry/opentelemetry-proto/blob/v1.8.0/opentelemetry/proto/collector/trace/v1/trace_service.proto#L30).
8888

89-
These enable user to ingest trace spans through [OTLP/HTTP](https://opentelemetry.io/docs/specs/otlp/#otlphttp) and [OTLP/gRPC](https://opentelemetry.io/docs/specs/otlp/#otlpgrpc).
89+
These enable user to ingest trace spans through [OTLP/HTTP](https://opentelemetry.io/docs/specs/otlp/#otlphttp) and [OTLP/gRPC](https://opentelemetry.io/docs/specs/otlp/#otlpgrpc).
9090

9191
To test the data ingestion, run the following command:
9292

9393
```shell
94-
echo '{"resourceSpans":[{"resource":{"attributes":[{"key":"service.name","value":{"stringValue":"frontend-web"}},{"key":"telemetry.sdk.language","value":{"stringValue":"webjs"}},{"key":"telemetry.sdk.name","value":{"stringValue":"opentelemetry"}},{"key":"telemetry.sdk.version","value":{"stringValue":"1.30.1"}},{"key":"process.runtime.name","value":{"stringValue":"browser"}},{"key":"process.runtime.description","value":{"stringValue":"Web Browser"}},{"key":"process.runtime.version","value":{"stringValue":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/136.0.0.0 Safari/537.36"}}]},"scopeSpans":[{"scope":{"name":"@opentelemetry/instrumentation-document-load","version":"0.44.1"},"spans":[{"traceId":"1af5dd013a30efe7f2970032ab81958b","spanId":"229d083a6c480511","parentSpanId":"","name":"documentLoad","kind":1,"startTimeUnixNano":"ingestTimePlaceHolder","endTimeUnixNano":"ingestTimePlaceHolder","attributes":[{"key":"session.id","value":{"stringValue":"96e702c3-6f05-4f54-b2b3-2fad2b7b7995"}},{"key":"http.url","value":{"stringValue":"http://frontend-proxy:8080/cart"}},{"key":"http.user_agent","value":{"stringValue":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/136.0.0.0 Safari/537.36"}}],"events":[{"timeUnixNano":"1757320936519100098","name":"fetchStart"}],"status":{}}]}]}]}' |
95-
sed "s/ingestTimePlaceHolder/$(date +%s000000000)/g" |
94+
echo '{"resourceSpans":[{"resource":{"attributes":[{"key":"service.name","value":{"stringValue":"frontend-web"}},{"key":"telemetry.sdk.language","value":{"stringValue":"webjs"}},{"key":"telemetry.sdk.name","value":{"stringValue":"opentelemetry"}},{"key":"telemetry.sdk.version","value":{"stringValue":"1.30.1"}},{"key":"process.runtime.name","value":{"stringValue":"browser"}},{"key":"process.runtime.description","value":{"stringValue":"Web Browser"}},{"key":"process.runtime.version","value":{"stringValue":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/136.0.0.0 Safari/537.36"}}]},"scopeSpans":[{"scope":{"name":"@opentelemetry/instrumentation-document-load","version":"0.44.1"},"spans":[{"traceId":"1af5dd013a30efe7f2970032ab81958b","spanId":"229d083a6c480511","parentSpanId":"","name":"documentLoad","kind":1,"startTimeUnixNano":"ingestTimePlaceHolder","endTimeUnixNano":"ingestTimePlaceHolder","attributes":[{"key":"session.id","value":{"stringValue":"96e702c3-6f05-4f54-b2b3-2fad2b7b7995"}},{"key":"http.url","value":{"stringValue":"http://frontend-proxy:8080/cart"}},{"key":"http.user_agent","value":{"stringValue":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/136.0.0.0 Safari/537.36"}}],"events":[{"timeUnixNano":"1757320936519100098","name":"fetchStart"}],"status":{}}]}]}]}' |
95+
sed "s/ingestTimePlaceHolder/$(date +%s000000000)/g" |
9696
curl -X POST -H 'Content-Type: application/json' --data-binary @- http://<victoria-traces>:10428/insert/opentelemetry/v1/traces
9797
```
9898

0 commit comments

Comments
 (0)