Incorrect tokenization of HLIL_STRUCT_FIELD in PseudoC and PseudoRust

[whitequark]

Version and Platform (required):

• Binary Ninja Version: 5.1.7598-test Ultimate (0e5168d7)
• Edition: Ultimate
• OS: Debian Linux
• OS Version: 13
• CPU Architecture: x86_64

Bug Description:
Lifter creates a dereference of a floating point value that was not in the disassembly. For some reason, the vcvt.s32.f32->vmov->sxth chain generates a pointer dereference.

Pseudo C (note the dereference; unfortunately not readable at all):

Pseudo Rust (note the deference):

Steps To Reproduce:

1. Open attached BNDB

Expected Behavior:
Binary Ninja to not make up dereferences of floating point values.

Binary:
bug_vfp.zip

[plafosse]

This is purely a Language Representation issue. The underlying instruction doesn't have a dereference in it but for some reason "HLIL_STRUCT_FIELD" is adding a * token. I've tracked this down to these particular lines of code:

Pseudo-C:

binaryninja-api/lang/c/pseudoc.cpp

Line 1487 in 5320c69

tokens.Append(OperationToken, "*");

Pseudo-Rust:

binaryninja-api/lang/rust/pseudorust.cpp

Line 1615 in 5320c69

tokens.Append(OperationToken, "*");

I don't know why this is being added. I really don't think it should be.