From 2fd49dd216fc82b5dc8b9b7075c66e1d812c10ce Mon Sep 17 00:00:00 2001 From: Anthony Yakovlev Date: Mon, 8 Dec 2025 16:01:41 +0300 Subject: [PATCH 1/4] don't add items that have no searchable name anyways --- .../Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packages/com.unity.inputsystem/InputSystem/Editor/Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs b/Packages/com.unity.inputsystem/InputSystem/Editor/Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs index 9ecbc3c07e..63552dd619 100644 --- a/Packages/com.unity.inputsystem/InputSystem/Editor/Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs +++ b/Packages/com.unity.inputsystem/InputSystem/Editor/Internal/AdvancedDropdown/AdvancedDropdownDataSource.cs @@ -118,7 +118,7 @@ private void BuildSearchableElements(AdvancedDropdownItem item) { if (!item.children.Any()) { - if (!item.IsSeparator()) + if (!item.IsSeparator() && item.searchableName.Length > 0) m_SearchableElements.Add(item); return; } From 2acc063cb476b4192a3537f8baea71e9d4cc5266 Mon Sep 17 00:00:00 2001 From: Anthony Yakovlev Date: Tue, 9 Dec 2025 12:06:23 +0300 Subject: [PATCH 2/4] update changelog --- Packages/com.unity.inputsystem/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md index 4e981b4547..1cc73d54eb 100644 --- a/Packages/com.unity.inputsystem/CHANGELOG.md +++ b/Packages/com.unity.inputsystem/CHANGELOG.md @@ -28,6 +28,7 @@ however, it has to be formatted properly to pass verification tests. - Deferred auto-registration of processors, interactions and composite binding types referenced by `InputActionAsset` to only happen once when an unresolved type reference is found in an action definition. This avoids reflective type loading from assemblies for all cases where the Input System is not extended. (ISXB-1766). +- Fixed extra empty lines being displayed in the control binding list when mouse buttons are pressed [ISXB-1677](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1677) ## [1.16.0] - 2025-11-10 From f67364913fff87fc7912181a130e602daf01bfef Mon Sep 17 00:00:00 2001 From: Anthony Yakovlev Date: Wed, 10 Dec 2025 15:16:04 +0300 Subject: [PATCH 3/4] what if we only run this test if ugui is present --- Assets/Tests/InputSystem.Editor/UGUITests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Assets/Tests/InputSystem.Editor/UGUITests.cs b/Assets/Tests/InputSystem.Editor/UGUITests.cs index 6dd636e33f..e189960c1f 100644 --- a/Assets/Tests/InputSystem.Editor/UGUITests.cs +++ b/Assets/Tests/InputSystem.Editor/UGUITests.cs @@ -1,4 +1,4 @@ -#if UNITY_EDITOR && UNITY_6000_0_OR_NEWER +#if UNITY_EDITOR && UNITY_6000_0_OR_NEWER && UNITY_INPUT_SYSTEM_ENABLE_UI using System; using NUnit.Framework; using UnityEditor; From de288ab46645a2c21a508e6f582018cf497b7ed2 Mon Sep 17 00:00:00 2001 From: Paulius Dervinis Date: Wed, 10 Dec 2025 14:22:57 +0200 Subject: [PATCH 4/4] Update CHANGELOG.md --- Packages/com.unity.inputsystem/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md index 1cc73d54eb..e4e2d1bbb6 100644 --- a/Packages/com.unity.inputsystem/CHANGELOG.md +++ b/Packages/com.unity.inputsystem/CHANGELOG.md @@ -13,6 +13,7 @@ however, it has to be formatted properly to pass verification tests. ### Fixed - Fixed warnings being generated on Unity 6.4 and 6.5. (ISX-2395). +- Fixed extra empty lines being displayed in the control binding list when mouse buttons are pressed [ISXB-1677](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1677) ## [1.17.0] - 2025-11-25 @@ -28,7 +29,6 @@ however, it has to be formatted properly to pass verification tests. - Deferred auto-registration of processors, interactions and composite binding types referenced by `InputActionAsset` to only happen once when an unresolved type reference is found in an action definition. This avoids reflective type loading from assemblies for all cases where the Input System is not extended. (ISXB-1766). -- Fixed extra empty lines being displayed in the control binding list when mouse buttons are pressed [ISXB-1677](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1677) ## [1.16.0] - 2025-11-10