2021.2/builtin target custom editor #6923
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: #6921
Purpose of this PR
Fix for https://fogbugz.unity3d.com/f/cases/1380485/
The BuiltIn Target was not correctly honoring a custom editor GUI the way the URP and HDRP targets do. This change properly updates the TargetSetupContext with the name of a custom editor GUI if one is entered on the Target in the graph settings. This works for both the Lit and Unlit SubTargets.
Testing status
Manual testing according to the repro case in the bug report. Also added an Unlit ShaderGraph and associated material to ensure it works correctly there. Made sure I hit a breakpoint in the projects custom GUI.