Skip to content

2021.2/builtin target custom editor #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2021.2/staging
Choose a base branch
from

Conversation

esmelusina
Copy link
Contributor

@esmelusina esmelusina commented Jan 31, 2022

backport: #6921


Purpose of this PR

Fix for https://fogbugz.unity3d.com/f/cases/1380485/

The BuiltIn Target was not correctly honoring a custom editor GUI the way the URP and HDRP targets do. This change properly updates the TargetSetupContext with the name of a custom editor GUI if one is entered on the Target in the graph settings. This works for both the Lit and Unlit SubTargets.


Testing status

Manual testing according to the repro case in the bug report. Also added an Unlit ShaderGraph and associated material to ensure it works correctly there. Made sure I hit a breakpoint in the projects custom GUI.

@github-actions
Copy link

github-actions bot commented Jan 31, 2022

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/jobDefinition/.yamato%2Fall-shadergraph_builtin_lighting.yml%23PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@esmelusina esmelusina changed the base branch from master to 2021.2/staging January 31, 2022 23:49
@esmelusina esmelusina requested review from jessebarker and removed request for a team January 31, 2022 23:49
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants