Fix fees not calculated for first account to provide liquidity on a pair #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benber86 is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue originally raised in #363. The problem does not seem to be about how much an account provides on a pair, but rather if they were the first one to do so. In that case, the calculation of their ownership of the pool when they entered it will return a
NaNbecause it will try to divide by aliquidityTokenTotalSupplythat is equal to 0. The ownershipNaNat t0 will then affect all subsequent calculations, including the sum of fees, hence why it is eventually not displayed.