You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Supersedes #1131 — this issue is the consolidated spec.
What
Recover the valuable code from closed-unmerged PR #1108 ("fix: render permission state notices on template-switching page and authorize switch_template AJAX"). Either reopen the original PR if its branch still exists and the work remains valid, or cherry-pick/recreate the valuable changes in a fresh PR. If the work is obsolete or unsafe, document the evidence and close with rationale.
Rationale: The pulse prefetch flagged this PR as containing recoverable code and no open replacement PR exists. Losing these fixes means the template-switching page may not properly render permission state notices or authorize the switch_template AJAX action.
If branch deleted or stale: Create a fresh branch from the default branch and hand-apply/cherry-pick only the still-valid changes.
Verification: Run the repo-relevant lint/test/build commands affected by the recovered files.
Run npm run check (lint + phpstan + phpunit)
Run relevant gateway and template-switching tests
Note: Paths are not known until the PR diff is inspected. This is a salvage/recovery task, not a blind merge. Do not apply reviewer suggestions blindly — inspect and verify each change before applying.
Supersedes #1131 — this issue is the consolidated spec.
What
Recover the valuable code from closed-unmerged PR #1108 ("fix: render permission state notices on template-switching page and authorize switch_template AJAX"). Either reopen the original PR if its branch still exists and the work remains valid, or cherry-pick/recreate the valuable changes in a fresh PR. If the work is obsolete or unsafe, document the evidence and close with rationale.
Why
switch_templateAJAX action.How
npm run check(lint + phpstan + phpunit)Note: Paths are not known until the PR diff is inspected. This is a salvage/recovery task, not a blind merge. Do not apply reviewer suggestions blindly — inspect and verify each change before applying.
Acceptance Criteria
Context & Decisions
Contributors
cc: @superdav42