Skip to content

consolidated: recover closed-unmerged PR #1108 - template-switching permission notices and switch_template AJAX #1154

@superdav42

Description

@superdav42

Supersedes #1131 — this issue is the consolidated spec.

What

Recover the valuable code from closed-unmerged PR #1108 ("fix: render permission state notices on template-switching page and authorize switch_template AJAX"). Either reopen the original PR if its branch still exists and the work remains valid, or cherry-pick/recreate the valuable changes in a fresh PR. If the work is obsolete or unsafe, document the evidence and close with rationale.

Why

  • Problem: PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108 was closed without being merged, but contains valuable code fixes for the template-switching page permission state notices and AJAX authorization.
  • Risk: medium
  • Rationale: The pulse prefetch flagged this PR as containing recoverable code and no open replacement PR exists. Losing these fixes means the template-switching page may not properly render permission state notices or authorize the switch_template AJAX action.

How

  1. Inspect PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108 — review its diff, review comments, CI history, and linked issues to understand what changes were proposed.
  2. Check if branch still exists — verify whether the original branch from PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108 is still available in the repository.
  3. If branch exists and work is valid: Reopen the original PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108.
  4. If branch deleted or stale: Create a fresh branch from the default branch and hand-apply/cherry-pick only the still-valid changes.
  5. Verification: Run the repo-relevant lint/test/build commands affected by the recovered files.
    • Run npm run check (lint + phpstan + phpunit)
    • Run relevant gateway and template-switching tests

Note: Paths are not known until the PR diff is inspected. This is a salvage/recovery task, not a blind merge. Do not apply reviewer suggestions blindly — inspect and verify each change before applying.

Acceptance Criteria

Context & Decisions

Contributors

cc: @superdav42

Metadata

Metadata

Assignees

Labels

auto-dispatchconsolidatedIssue superseded by a consolidated childorigin:workerAuto-created by pulse labelless backfill (t2112)priority:highHigh severity — significant quality issuestatus:availableTask is available for claimingtier:thinkingRoute to opus-tier model for dispatch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions