consolidation-task: merge thread on #1131 into single spec

[superdav42]

Consolidation target: #1131

Parent issue: #1131 in Ultimate-Multisite/ultimate-multisite
Parent title: Recover closed-unmerged PR #1108: fix: render permission state notices on template-switching page and authorize switch_template AJAX
Parent labels: priority:high,auto-dispatch,status:available,origin:worker,consolidation-in-progress

You do NOT need to read #1131. Everything required is inlined below.
Reading the parent wastes the token budget and is explicitly disallowed for this task.

What to do

1. Read the parent body and substantive comments inlined below. Identify:

   • The original problem statement
   • Scope modifications added by commenters (additions, corrections, clarifications)
   • Resolved questions, rejected ideas, or superseded decisions
   • The final agreed-upon approach

2. Compose a single coherent issue body in the aidevops brief format (see templates/brief-template.md):

   • ## What — the deliverable
   • ## Why — the problem and rationale
   • ## How — approach with explicit file paths and line references
   • ## Acceptance Criteria — testable checkboxes
   • ## Context & Decisions — which commenter contributed which insight (attribution matters)
   • ## Contributors — a cc line @-mentioning every author from the list below

   Start the merged body with: _Supersedes #1131 — this issue is the consolidated spec._

3. File the new consolidated issue:

gh issue create --repo "Ultimate-Multisite/ultimate-multisite" \
  --title "consolidated: <concise description derived from the merged spec>" \
  --label "consolidated,origin:worker,<copy relevant labels from parent, excluding needs-consolidation, consolidation-task, and origin:interactive>" \
  --body "<merged body from step 2>"

Note (GH#18670): origin:worker is mandatory on this label list — consolidated issues are pulse-generated artifacts, not interactive maintainer work. Without it, the issue is born origin:interactive (raw gh issue create has no origin auto-detection), which triggers the GH#18352 dispatch-dedup block and drains the queue.

Capture the new issue number as $NEW_NUM.

4. Close the parent Recover closed-unmerged PR #1108: fix: render permission state notices on template-switching page and authorize switch_template AJAX #1131:

gh issue comment 1131 --repo "Ultimate-Multisite/ultimate-multisite" \
  --body "Superseded by #$NEW_NUM. The merged spec is inlined on the new issue — continue discussion there."
gh issue edit 1131 --repo "Ultimate-Multisite/ultimate-multisite" \
  --add-label "consolidated" --remove-label "needs-consolidation"
gh issue close 1131 --repo "Ultimate-Multisite/ultimate-multisite" --reason "not planned"

5. Close this consolidation-task issue with a summary comment:

gh issue comment $THIS_ISSUE --repo "Ultimate-Multisite/ultimate-multisite" \
  --body "Consolidation complete. Parent: #1131 → New: #$NEW_NUM. Contributors @-mentioned: @superdav42."
gh issue close $THIS_ISSUE --repo "Ultimate-Multisite/ultimate-multisite" --reason "completed"

Constraints

• Do NOT read Recover closed-unmerged PR #1108: fix: render permission state notices on template-switching page and authorize switch_template AJAX #1131 — it is inlined below. Reading it wastes the token budget.
• Preserve all substantive content. Merging is not summarising. If a comment adds a constraint, that constraint must appear in the merged body.
• Preserve author attribution for specific contributions: "per @user1: …".
• No PR is required. This is an operational task. The completion signal is the new issue number + parent closure + self-close.
• Contributors to @-mention on the new issue: @superdav42

Parent body (verbatim)

Recover valuable code from closed-unmerged PR #1108: fix: render permission state notices on template-switching page and authorize switch_template AJAX

Goal

Review the closed-unmerged PR and either reopen it if it is still correct, or cherry-pick/recreate the valuable changes in a fresh PR. If the work is obsolete or unsafe, document the evidence and close this issue with rationale.

Context

• Source PR: fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108
• Risk: medium
• The pulse prefetch flagged this PR as containing recoverable code and no open replacement PR.

Suggested approach

1. Inspect PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108, its diff, review comments, CI history, and linked issues.
2. Prefer reopening the original PR when its branch still exists and the work remains valid.
3. If the branch is deleted or stale, create a fresh branch from the default branch and hand-apply/cherry-pick only the still-valid changes.
4. Do not apply reviewer suggestions blindly; inspect and verify each change.

Verification

• Run the repo-relevant lint/test/build commands affected by the recovered files.
• In the PR body, link this issue and the source PR fix: render permission state notices on template-switching page and authorize switch_template AJAX #1108, and summarize what was recovered vs intentionally omitted.

Notes for worker

Paths are not known until the PR diff is inspected. Treat this as a salvage/recovery task, not a blind merge.

---

aidevops.sh v3.14.75 plugin for OpenCode v1.14.33 with gpt-5.5 spent 5m and 124,265 tokens on this as a headless worker.

Substantive comments (verbatim, in chronological order)

Comment 1 — @superdav42 at 2026-05-06T23:59:52Z

Escalation Blocked: Missing Implementation Context

Trigger: 1 consecutive worker failures (threshold: 1)
Action: Escalation skipped — issue body lacks file paths and implementation steps.

Workers fail when they must explore the entire codebase to find what to change. Adding explicit file paths, reference patterns, and verification commands to the issue body is more effective than escalating to a more expensive model.

Required: Update the issue body with a ## How section containing:

• Files to modify (with paths and line ranges)
• Reference pattern (model on <existing-file>)
• Verification command

Automated by escalate_issue_tier() body quality gate (t1900) in worker-lifecycle-common.sh

---

aidevops.sh v3.14.83 plugin for OpenCode v1.14.33 with claude-sonnet-4-6 spent 2d 19h on this as a headless worker.

---

Comment 2 — @superdav42 at 2026-05-07T09:27:05Z

Escalation Blocked: Missing Implementation Context

Trigger: 1 consecutive worker failures (threshold: 1)
Action: Escalation skipped — issue body lacks file paths and implementation steps.

Workers fail when they must explore the entire codebase to find what to change. Adding explicit file paths, reference patterns, and verification commands to the issue body is more effective than escalating to a more expensive model.

Required: Update the issue body with a ## How section containing:

• Files to modify (with paths and line ranges)
• Reference pattern (model on <existing-file>)
• Verification command

Automated by escalate_issue_tier() body quality gate (t1900) in worker-lifecycle-common.sh

---

aidevops.sh v3.14.86 plugin for OpenCode v1.14.40 with gemma4:e4b spent 3h 11m and 263,673 tokens on this as a headless worker.

---

Self-contained dispatch packet generated by _dispatch_issue_consolidation() in pulse-triage.sh (t1982). Everything above is sufficient — do not read #1131.

[superdav42]

DISPATCH_CLAIM nonce=b8bf53fdb3a2c920623c847ad58484da runner=superdav42 ts=2026-05-07T16:18:37Z max_age_s=1800 version=3.14.87 opencode_version=1.14.40

[superdav42]

Dispatching worker (deterministic).

• Worker PID: 1068276
• Model: opencode/minimax-m2.5-free
• Tier: standard
• Runner: superdav42
• aidevops: v3.14.87
• OpenCode: v1.14.40
• Issue: consolidation-task: merge thread on #1131 into single spec #1152

[superdav42]

Consolidation complete. Parent: #1131 → New: #1154. Contributors @-mentioned: @superdav42.

[superdav42]

CLAIM_RELEASED reason=worker_noop runner=dave ts=2026-05-07T16:20:45Z aidevops_version=3.14.88 opencode_version=1.14.40