Skip to content

Improve and fix mass delete old medias #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Improve and fix mass delete old medias #45

wants to merge 20 commits into from

Conversation

@fthiery
Copy link
Contributor

@fthiery fthiery commented Jul 8, 2025 •
edited
Loading

This PR

  • adds a way to test if SMTP settings work
  • fixes various bugs
  • uses the new API call to determine if the trash is enabled (and exits otherwise)

TODO:

  • revert 60d4324 and add test with views_max_count=0
  • test resume mecanism of EmailSender
  • add test case in order to verify category case insensitivity 895032b
  • add test case if trash is not enabled
  • add test for --send-test-email-to

fthiery added 20 commits July 8, 2025 17:51
@fthiery
add --send-test-email-to switch
6c4715c
@fthiery
log to file
3757a2b
@fthiery
use TLS1.2 and STARTTLS
c86c812
@fthiery
factorize smtp code
fdf49d0
@fthiery
fix crash
23ad1d9
@fthiery
auto-determine if trash is enabled or not using the new api call
1f50c16
@fthiery
fix logic: watched content would get selected for deletion even if th…
60d4324 
…ere were views
@fthiery
make skip category comparison case insensitive
895032b
@fthiery
track sent emails so that an interrupted session can be resumed in ca…
8740a58 
…se of crash when sending emails
@fthiery
replace smtp context manager by EmailSender class
4d3620d
@fthiery
auto finalize session on exit if there was no exception
e2f093d
@fthiery
Only fallback in case of SMTPRecipientsRefused
c56a8ad
@fthiery
fix helptext
ebb324f
@fthiery
remove unused variables
97ebf2a
@fthiery
fix formatting
961ace7
@fthiery
fix dead code warning
9eb84b3
@fthiery
fix regressions in fixtures
c02efae
@fthiery
fix test
5b2bdc6
@fthiery
fix pep8
d5e1215
@fthiery
[wip] try to fix unwatched bug
604b46a
@thomas-mckay thomas-mckay self-assigned this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomas-mckay thomas-mckay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fthiery @thomas-mckay