-
Notifications
You must be signed in to change notification settings - Fork 203
feat: adds a standalone transaction-clearer bot for recovering from nonce backlogs. #4915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
fa2773f
e448f44
e7077cc
1e03e77
dd0c8b7
8744689
e706178
f4ba316
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| import { BigNumber } from "ethers"; | ||
| import type { Logger as LoggerType } from "winston"; | ||
| import type { Provider } from "@ethersproject/abstract-provider"; | ||
| import type { Signer } from "ethers"; | ||
| import { GasEstimator } from "@uma/financial-templates-lib"; | ||
|
|
||
| export interface NonceBacklogConfig { | ||
| // Minimum nonce difference (pending - latest) to trigger clearing | ||
| nonceBacklogThreshold: number; | ||
| // Fee bump percentage per attempt (e.g., 20 means 20% increase) | ||
| feeBumpPercent: number; | ||
| // Max attempts to replace a stuck transaction with increasing fees | ||
| replacementAttempts: number; | ||
| } | ||
|
|
||
| export interface TransactionClearingParams { | ||
| provider: Provider; | ||
| signer: Signer; | ||
| nonceBacklogConfig: NonceBacklogConfig; | ||
| } | ||
|
|
||
| type FeeData = { maxFeePerGas: BigNumber; maxPriorityFeePerGas: BigNumber } | { gasPrice: BigNumber }; | ||
|
|
||
| function isLondonFeeData(feeData: FeeData): feeData is { maxFeePerGas: BigNumber; maxPriorityFeePerGas: BigNumber } { | ||
| return "maxFeePerGas" in feeData; | ||
| } | ||
|
|
||
| export const parsePositiveInt = (value: string | undefined, defaultValue: number, name: string): number => { | ||
| if (value === undefined) return defaultValue; | ||
| const parsed = Number(value); | ||
| if (!Number.isFinite(parsed) || parsed <= 0 || !Number.isInteger(parsed)) { | ||
| throw new Error(`${name} must be a positive integer, got: ${value}`); | ||
| } | ||
| return parsed; | ||
| }; | ||
|
|
||
| export const getNonceBacklogConfig = (env: NodeJS.ProcessEnv): NonceBacklogConfig => { | ||
| return { | ||
| nonceBacklogThreshold: parsePositiveInt(env.NONCE_BACKLOG_THRESHOLD, 1, "NONCE_BACKLOG_THRESHOLD"), | ||
| feeBumpPercent: parsePositiveInt(env.NONCE_REPLACEMENT_BUMP_PERCENT, 20, "NONCE_REPLACEMENT_BUMP_PERCENT"), | ||
| replacementAttempts: parsePositiveInt(env.NONCE_REPLACEMENT_ATTEMPTS, 3, "NONCE_REPLACEMENT_ATTEMPTS"), | ||
| }; | ||
| }; | ||
|
|
||
| function bumpFeeData(baseFeeData: FeeData, attemptIndex: number, config: NonceBacklogConfig): FeeData { | ||
| // Calculate multiplier: ((100 + percent) / 100)^(attemptIndex+1) | ||
| // For attempt 0: 1.2x, attempt 1: 1.44x, attempt 2: 1.73x (with default 20%) | ||
| const bumpValue = (value: BigNumber): BigNumber => { | ||
| let bumped = value; | ||
| for (let i = 0; i <= attemptIndex; i++) { | ||
| bumped = bumped.mul(100 + config.feeBumpPercent).div(100); | ||
| } | ||
| return bumped; | ||
| }; | ||
|
|
||
| if (isLondonFeeData(baseFeeData)) { | ||
| return { | ||
| maxFeePerGas: bumpValue(baseFeeData.maxFeePerGas), | ||
| maxPriorityFeePerGas: bumpValue(baseFeeData.maxPriorityFeePerGas), | ||
| }; | ||
| } else { | ||
| return { | ||
| gasPrice: bumpValue(baseFeeData.gasPrice), | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| async function getNonces(provider: Provider, address: string): Promise<{ latestNonce: number; pendingNonce: number }> { | ||
| const [latestNonce, pendingNonce] = await Promise.all([ | ||
| provider.getTransactionCount(address, "latest"), | ||
| provider.getTransactionCount(address, "pending"), | ||
| ]); | ||
| return { latestNonce, pendingNonce }; | ||
| } | ||
|
|
||
| /** | ||
| * Clears stuck transactions by sending self-transactions with higher gas fees. | ||
| * @returns true if a nonce backlog was detected and clearing was attempted | ||
| */ | ||
| export async function clearStuckTransactions( | ||
| logger: LoggerType, | ||
| params: TransactionClearingParams, | ||
| gasEstimator: GasEstimator | ||
| ): Promise<boolean> { | ||
| const { provider, signer, nonceBacklogConfig } = params; | ||
| const botAddress = await signer.getAddress(); | ||
|
|
||
| const { latestNonce, pendingNonce } = await getNonces(provider, botAddress); | ||
| const backlog = pendingNonce - latestNonce; | ||
|
|
||
| if (backlog < nonceBacklogConfig.nonceBacklogThreshold) { | ||
| logger.debug({ | ||
| at: "TransactionClearer", | ||
| message: "No nonce backlog detected", | ||
| botAddress, | ||
| latestNonce, | ||
| pendingNonce, | ||
| backlog, | ||
| threshold: nonceBacklogConfig.nonceBacklogThreshold, | ||
| }); | ||
| return false; | ||
| } | ||
|
|
||
| logger.warn({ | ||
| at: "TransactionClearer", | ||
| message: "Nonce backlog detected, attempting to clear stuck transactions", | ||
| botAddress, | ||
| latestNonce, | ||
| pendingNonce, | ||
| backlog, | ||
| threshold: nonceBacklogConfig.nonceBacklogThreshold, | ||
| }); | ||
|
|
||
| // Get base fee data from gas estimator | ||
| const baseFeeData = gasEstimator.getCurrentFastPriceEthers(); | ||
|
|
||
| // Clear all stuck nonces from latestNonce to pendingNonce - 1 | ||
| // Track current state as it may change during clearing | ||
| let currentLatestNonce = latestNonce; | ||
| let currentPendingNonce = pendingNonce; | ||
|
|
||
| while (currentLatestNonce < currentPendingNonce) { | ||
| const nonce = currentLatestNonce; | ||
| let cleared = false; | ||
|
|
||
| for (let attempt = 0; attempt < nonceBacklogConfig.replacementAttempts; attempt++) { | ||
| const feeData = bumpFeeData(baseFeeData, attempt, nonceBacklogConfig); | ||
|
|
||
| try { | ||
| logger.info({ | ||
| at: "TransactionClearer", | ||
| message: `Attempting to clear stuck transaction (nonce ${nonce}, attempt ${attempt + 1})`, | ||
| botAddress, | ||
| nonce, | ||
| attempt: attempt + 1, | ||
| feeData: isLondonFeeData(feeData) | ||
| ? { | ||
| maxFeePerGas: feeData.maxFeePerGas.toString(), | ||
| maxPriorityFeePerGas: feeData.maxPriorityFeePerGas.toString(), | ||
| } | ||
| : { gasPrice: feeData.gasPrice.toString() }, | ||
| }); | ||
|
|
||
| const tx = await signer.sendTransaction({ | ||
| to: botAddress, // Self-transaction | ||
| value: 0, | ||
| nonce, | ||
| gasLimit: 21_000, | ||
| ...feeData, | ||
| }); | ||
|
|
||
| const receipt = await tx.wait(1); | ||
|
|
||
| logger.info({ | ||
| at: "TransactionClearer", | ||
| message: `Successfully cleared stuck transaction (nonce ${nonce})`, | ||
| botAddress, | ||
| nonce, | ||
| transactionHash: receipt.transactionHash, | ||
| gasUsed: receipt.gasUsed.toString(), | ||
| }); | ||
|
|
||
| cleared = true; | ||
| break; | ||
| } catch (error) { | ||
| logger.warn({ | ||
| at: "TransactionClearer", | ||
| message: `Failed to clear stuck transaction (nonce ${nonce}, attempt ${attempt + 1})`, | ||
| botAddress, | ||
| nonce, | ||
| attempt: attempt + 1, | ||
| error: error instanceof Error ? error.message : String(error), | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| if (!cleared) { | ||
| logger.error({ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this could end up paging indefinitely if clearing transactions end up underpriced and we are not updating |
||
| at: "TransactionClearer", | ||
| message: `Failed to clear stuck transaction after all attempts (nonce ${nonce})`, | ||
| botAddress, | ||
| nonce, | ||
| maxAttempts: nonceBacklogConfig.replacementAttempts, | ||
| }); | ||
|
|
||
| // Re-evaluate nonce state before continuing - the stuck tx may have been | ||
| // cleared by another source, or new transactions may have been submitted | ||
| const refreshed = await getNonces(provider, botAddress); | ||
| currentLatestNonce = refreshed.latestNonce; | ||
| currentPendingNonce = refreshed.pendingNonce; | ||
|
Comment on lines
+188
to
+190
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't this exit the loop after |
||
|
|
||
| logger.info({ | ||
| at: "TransactionClearer", | ||
| message: "Re-evaluated nonce state after failed clearing attempt", | ||
| botAddress, | ||
| previousNonce: nonce, | ||
| newLatestNonce: currentLatestNonce, | ||
| newPendingNonce: currentPendingNonce, | ||
| }); | ||
| } else { | ||
| // Move to next nonce after successful clear | ||
| currentLatestNonce++; | ||
| } | ||
| } | ||
|
|
||
| // Verify final state - once we start clearing, we aim to clear all pending transactions | ||
| const { latestNonce: finalLatestNonce, pendingNonce: finalPendingNonce } = await getNonces(provider, botAddress); | ||
| const finalBacklog = finalPendingNonce - finalLatestNonce; | ||
|
|
||
| if (finalBacklog === 0) { | ||
| logger.info({ | ||
| at: "TransactionClearer", | ||
| message: "Successfully cleared all pending transactions", | ||
| botAddress, | ||
| previousBacklog: backlog, | ||
| finalBacklog, | ||
| }); | ||
| } else { | ||
| logger.warn({ | ||
| at: "TransactionClearer", | ||
| message: "Some pending transactions remain after clearing attempt", | ||
| botAddress, | ||
| previousBacklog: backlog, | ||
| finalBacklog, | ||
| }); | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { Logger as LoggerType } from "winston"; | ||
| import { GasEstimator } from "@uma/financial-templates-lib"; | ||
| import { MonitoringParams } from "./common"; | ||
| import { clearStuckTransactions as clearStuckTransactionsImpl } from "../bot-utils/transactionClearing"; | ||
|
|
||
| export async function clearStuckTransactions( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. might be more maintainable in the future if we have a single tx clearing module here and |
||
| logger: LoggerType, | ||
| params: MonitoringParams, | ||
| gasEstimator: GasEstimator | ||
| ): Promise<void> { | ||
| await clearStuckTransactionsImpl(logger, params, gasEstimator); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export { Logger } from "@uma/financial-templates-lib"; | ||
| import { BaseMonitoringParams, initBaseMonitoringParams, startupLogLevel as baseStartup } from "../bot-utils/base"; | ||
| import { getNonceBacklogConfig, NonceBacklogConfig } from "../bot-utils/transactionClearing"; | ||
|
|
||
| export interface MonitoringParams extends BaseMonitoringParams { | ||
| nonceBacklogConfig: NonceBacklogConfig; | ||
| } | ||
|
|
||
| export const initMonitoringParams = async (env: NodeJS.ProcessEnv): Promise<MonitoringParams> => { | ||
| const base = await initBaseMonitoringParams(env); | ||
|
|
||
| return { | ||
| ...base, | ||
| nonceBacklogConfig: getNonceBacklogConfig(env), | ||
| }; | ||
| }; | ||
|
|
||
| export const startupLogLevel = baseStartup; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| // Standalone bot for clearing stuck transactions via self-tx replacement. | ||
| import { delay, waitForLogger, GasEstimator } from "@uma/financial-templates-lib"; | ||
| import { initMonitoringParams, Logger, startupLogLevel } from "./common"; | ||
| import { clearStuckTransactions } from "./TransactionClearer"; | ||
|
|
||
| const logger = Logger; | ||
|
|
||
| async function main() { | ||
| const params = await initMonitoringParams(process.env); | ||
|
|
||
| logger[startupLogLevel(params)]({ | ||
| at: "TransactionClearer", | ||
| message: "Transaction Clearer Bot started", | ||
| chainId: params.chainId, | ||
| nonceBacklogConfig: params.nonceBacklogConfig, | ||
| }); | ||
|
|
||
| const gasEstimator = new GasEstimator(logger, undefined, params.chainId, params.provider); | ||
|
|
||
| for (;;) { | ||
| await gasEstimator.update(); | ||
|
|
||
| try { | ||
| await clearStuckTransactions(logger, params, gasEstimator); | ||
| } catch (error) { | ||
| logger.error({ | ||
| at: "TransactionClearer", | ||
| message: "Error clearing stuck transactions", | ||
| error, | ||
| }); | ||
| } | ||
|
|
||
| if (params.pollingDelay !== 0) { | ||
| await delay(params.pollingDelay); | ||
| } else { | ||
| await delay(5); // Allow transports to flush | ||
| await waitForLogger(logger); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| main().then( | ||
| () => { | ||
| process.exit(0); | ||
| }, | ||
| async (error) => { | ||
| logger.error({ | ||
| at: "TransactionClearer", | ||
| message: "Transaction Clearer Bot execution error", | ||
| error, | ||
| }); | ||
| await delay(5); | ||
| await waitForLogger(logger); | ||
| process.exit(1); | ||
| } | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth continuing with clearing next nonces if this one failed all attempts? Or we shall better reevaluate current state of pending-latest as some earlier tx might have been mined or another bot instance submits new tx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. Now re-evaluates nonce state after failed attempts before continuing so it handles cases where the stuck tx got mined elsewhere or new txs were submitted.