Fixed live view regex causing a crash when regex is invalid

Author: UE4SS

UE4SS/include/ExceptionHandling.hpp

@@ -5,6 +5,16 @@
 #include <DynamicOutput/DynamicOutput.hpp>
 #include <Helpers/String.hpp>
 
+#define UE4SS_ERROR_OUTPUTTER()                                                                                                                                \
+    if (!Output::has_internal_error())                                                                                                                         \
+    {                                                                                                                                                          \
+        Output::send<LogLevel::Error>(STR("Error: {}\n"), to_wstring(e.what()));                                                                               \
+    }                                                                                                                                                          \
+    else                                                                                                                                                       \
+    {                                                                                                                                                          \
+        printf_s("Internal Error: %s\n", e.what());                                                                                                            \
+    }
+
 namespace RC
 {
     // Will try some code and properly propagate any exceptions
@@ -18,14 +28,7 @@ namespace RC
         }
         catch (std::exception& e)
         {
-            if (!Output::has_internal_error())
-            {
-                Output::send<LogLevel::Error>(STR("Error: {}\n"), to_wstring(e.what()));
-            }
-            else
-            {
-                printf_s("Internal Error: %s\n", e.what());
-            }
+            UE4SS_ERROR_OUTPUTTER()
 
             using LambdaReturnType = decltype(code_to_try());
             if constexpr (!std::is_same_v<LambdaReturnType, void>)

UE4SS/include/GUI/LiveView.hpp

@@ -195,6 +195,14 @@ namespace RC::GUI
                 -> void;
 
       public:
+        auto set_is_searching_by_name(bool new_value) -> void
+        {
+            m_is_searching_by_name = new_value;
+        }
+        auto set_search_field_clear_requested(bool new_value) -> void
+        {
+            m_search_field_clear_requested = new_value;
+        }
         auto was_search_field_clear_requested() -> bool
         {
             return m_search_field_clear_requested;

UE4SS/src/GUI/LiveView.cpp

@@ -88,6 +88,8 @@ namespace RC::GUI
     bool LiveView::s_watches_loaded_from_disk{};
     bool LiveView::s_use_regex_for_search{};
 
+    static LiveView* s_live_view{};
+
     static auto get_object_full_name_cxx_string(UObject* object) -> std::string;
 
     static auto filter_out_objects(UObject* object) -> bool
@@ -149,10 +151,20 @@ namespace RC::GUI
 
         if (LiveView::s_use_regex_for_search)
         {
-            if (std::regex_search(object_full_name.begin(), object_full_name.end(), std::regex(name_to_search_by)))
+            try
+            {
+                if (std::regex_search(object_full_name.begin(), object_full_name.end(), std::regex(name_to_search_by)))
+                {
+                    LiveView::s_name_search_results.emplace_back(object);
+                    LiveView::s_name_search_results_set.emplace(object);
+                }
+            }
+            catch (std::exception& e)
             {
-                LiveView::s_name_search_results.emplace_back(object);
-                LiveView::s_name_search_results_set.emplace(object);
+                UE4SS_ERROR_OUTPUTTER()
+                LiveView::s_name_to_search_by.clear();
+                s_live_view->set_is_searching_by_name(false);
+                s_live_view->set_search_field_clear_requested(true);
             }
             return;
         }
@@ -874,6 +886,8 @@ namespace RC::GUI
                   m_default_search_buffer.size() + sizeof(char),
                   m_default_search_buffer.data(),
                   m_default_search_buffer.size() + sizeof(char));
+
+        s_live_view = this;
     }
 
     LiveView::~LiveView()