Better unhand exception whitout try-catch

Author: ricardopolo

Tulpep.NetworkAutoSwitch.Service/ManageNetworkState.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
 using System.Net.NetworkInformation;

Tulpep.NetworkAutoSwitch.Service/Program.cs

@@ -15,53 +15,39 @@ static class Program
         static int Main(string[] args)
         {
 
+            AppDomain.CurrentDomain.UnhandledException += CurrentDomainUnhandledException;
+
             if (Environment.UserInteractive)
             {
-                string parameter = string.Concat(args);
-                try
+                switch (string.Concat(args))
                 {
-                    switch (parameter)
-                    {
-                        case "--install":
-                            ManagedInstallerClass.InstallHelper(new string[] { Assembly.GetExecutingAssembly().Location });
-                            Console.WriteLine("Service Installed");
-                            const string serviceName = "NetworkAutoSwitch";
-                            int timeout = 5000;
-                            Console.WriteLine(String.Format("Starting Windows Service {0} with timeout of {1} ms", serviceName, timeout));
-                            Console.WriteLine("Service running");
-                            StartService(serviceName, timeout);
-                            return 0;
-                        case "--uninstall":
-                            ManagedInstallerClass.InstallHelper(new string[] { "/u", Assembly.GetExecutingAssembly().Location });
-                            Console.WriteLine("Service Uninstalled");
-                            return 0;
-                        default:
-                            Console.WriteLine("Use parameters --install or --uninstall to use as Windows Service");
-                            var exitEvent = new ManualResetEvent(false);
-                            Console.CancelKeyPress += (sender, eventArgs) => {
-                                eventArgs.Cancel = true;
-                                exitEvent.Set();
-                            };
-                            try
-                            {
-                                DetectNetworkChanges detectNetworkChanges = new DetectNetworkChanges();
-                                Console.WriteLine("Press CTRL + C to exit...");
-                                exitEvent.WaitOne();
-                                detectNetworkChanges.StopNow();
-                                return 0;
-                            }
-                            catch (Exception ex)
-                            {
-                                Logging.WriteMessage(ex.ToString());
-                                return 1;
-                            }
+                    case "--install":
+                        ManagedInstallerClass.InstallHelper(new string[] { Assembly.GetExecutingAssembly().Location });
+                        Console.WriteLine("Service Installed");
+                        const string serviceName = "NetworkAutoSwitch";
+                        int timeout = 5000;
+                        Console.WriteLine(String.Format("Starting Windows Service {0} with timeout of {1} ms", serviceName, timeout));
+                        Console.WriteLine("Service running");
+                        StartService(serviceName, timeout);
+                        return 0;
+                    case "--uninstall":
+                        ManagedInstallerClass.InstallHelper(new string[] { "/u", Assembly.GetExecutingAssembly().Location });
+                        Console.WriteLine("Service Uninstalled");
+                        return 0;
+                    default:
+                        Console.WriteLine("Use parameters --install or --uninstall to use as Windows Service");
+                        var exitEvent = new ManualResetEvent(false);
+                        Console.CancelKeyPress += (sender, eventArgs) => {
+                            eventArgs.Cancel = true;
+                            exitEvent.Set();
+                        };
+
+                        DetectNetworkChanges detectNetworkChanges = new DetectNetworkChanges();
+                        Console.WriteLine("Press CTRL + C to exit...");
+                        exitEvent.WaitOne();
+                        detectNetworkChanges.StopNow();
+                        return 0;
 
-                    }
-                }
-                catch (Exception ex)
-                {
-                    Console.WriteLine("Error: " + ex.Message);
-                    return 1;
                 }
             }
             else
@@ -77,6 +63,13 @@ static int Main(string[] args)
 
         }
 
+        private static void CurrentDomainUnhandledException(object sender, UnhandledExceptionEventArgs e)
+        {
+            Logging.WriteMessage(e.ExceptionObject.ToString());
+            Environment.Exit(1);
+        }
+
+
         private static void StartService(string serviceName, int timeoutMilliseconds)
         {
             ServiceController service = new ServiceController(serviceName);